Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support to SkillDialog so SSO works with expectReply #5780

Closed
6 tasks done
gabog opened this issue Mar 13, 2020 · 0 comments
Closed
6 tasks done

Add support to SkillDialog so SSO works with expectReply #5780

gabog opened this issue Mar 13, 2020 · 0 comments
Labels
P1 Painful if we don't fix, won't block releasing

Comments

@gabog
Copy link
Contributor

gabog commented Mar 13, 2020 •
edited
Loading

Currently SSO works with SkillDialog when using the default back to back http request response communication with a skill because there's custom logic in SkillHanlder.

But this doesn't work when using SkillDialog and expected replies.

We need to add logic to SkillDIalog to handle this use case.

Dotnet SDK (Tracked in issue)

Javascript SDK (Tracked in issue)

Python SDK (Tracked in issue)

  • PR
  • Merged
@gabog gabog added R9 Release 9 - May 15th, 2020 Skills labels Mar 13, 2020
@gabog gabog changed the title Add support to SkillDialog so SSO works when Add support to SkillDialog so SSO works when using expectReplies Mar 13, 2020
@clearab clearab changed the title Add support to SkillDialog so SSO works when using expectReplies Add support to SkillDialog so SSO works with expectReply Apr 3, 2020
This was referenced Apr 3, 2020
Closed
Closed
Closed
@clearab clearab added P1 Painful if we don't fix, won't block releasing and removed R9 Release 9 - May 15th, 2020 labels Apr 3, 2020
@clearab clearab closed this as completed May 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P1 Painful if we don't fix, won't block releasing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@clearab @gabog