Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for "Run Current Query" keybind no longer behaving as expected (#… #10804

Merged
merged 1 commit into from
Jun 9, 2020

Conversation

aasimkhan30
Copy link
Contributor

…10538) (#10557)

  • -"Run current" command runs the entire selection instead of only first statement in the selection

  • -brought some logic back from the old code to correct the behavior

  • -Added unit tests for runCurrent command

  • -Fixed a comment

    • Added checks for run input parameters
  • -Added some extra checks

  • -Fixed some spacing issue

  • Changed to using verify instead of a counter variable

This PR fixes #

…10538) (#10557)

* -"Run current" command runs the entire selection instead of only first statement in the selection

* -brought some logic back from the  old code to correct the behavior

* -Added unit tests for runCurrent command

* -Fixed a comment

* - Added checks for run input parameters

* -Added some extra checks

* -Fixed some spacing issue

* Changed to using verify instead of a counter variable
@aasimkhan30
Copy link
Contributor Author

@kenvanhyning This PR fixes #10557. The changes are already merged in the master. Please approve it for the release branch.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 34.282% when pulling 9b6e640 on aasim/release/1.19/runQuery into 9962363 on release/1.19.

@kburtram kburtram merged commit 5de8b06 into release/1.19 Jun 9, 2020
@kburtram kburtram deleted the aasim/release/1.19/runQuery branch June 9, 2020 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants