"Run Current Query" keybind no longer behaving as expected #10538
Comments
abist
changed the title
|
I'll close this issue based on the workaround in release/1.18. We can use one of the duplicate issues to track the longer-term fix in master. @JFitzMan a hotfix for this is planned for tomorrow if no other blocking bugs are found. |
aasimkhan30
added a commit
that referenced
this issue
Jun 8, 2020
…10538) (#10557) * -"Run current" command runs the entire selection instead of only first statement in the selection * -brought some logic back from the old code to correct the behavior * -Added unit tests for runCurrent command * -Fixed a comment * - Added checks for run input parameters * -Added some extra checks * -Fixed some spacing issue * Changed to using verify instead of a counter variable
aasimkhan30
added a commit
that referenced
this issue
Jun 8, 2020
…10538) (#10557) * -"Run current" command runs the entire selection instead of only first statement in the selection * -brought some logic back from the old code to correct the behavior * -Added unit tests for runCurrent command * -Fixed a comment * - Added checks for run input parameters * -Added some extra checks * -Fixed some spacing issue * Changed to using verify instead of a counter variable
kburtram
pushed a commit
that referenced
this issue
Jun 9, 2020
…10538) (#10557) (#10804) * -"Run current" command runs the entire selection instead of only first statement in the selection * -brought some logic back from the old code to correct the behavior * -Added unit tests for runCurrent command * -Fixed a comment * - Added checks for run input parameters * -Added some extra checks * -Fixed some spacing issue * Changed to using verify instead of a counter variable
|
Fixed in release/1.19. Let's sync up in future meeting how to avoid regressions related to fixes directly in release branches. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Issue Type: Bug
In previous versions the expected behavior of this keybind was to run either the currently selected query or run whichever query the cursor was currently active on. This also used to be able to handle comments included within the queries and selections, as well as multiple queries in the same batch. There are a couple of easily reproducable issues now:
Pressing this keybind now runs the entire script regardless of cursor position.
Highlighting multiple queries and pressing this keybind results in only the top query being run. In the past, it would run the entire selection. Example: highlight and run both of these in the same batch
select 1
select 1
If there is a comment above a query and you include this in the highlighted text, the query will not run. Example: highlight the comment and the select and run.
-- the following gets 1
select 1
If you have a query commented out and highlight it to run, it will not run. Example: run the select 1 by highlighting everything besides the comment characters
-- select 1
Azure Data Studio version: azuredatastudio 1.18.0 (2acd37a, 2020-05-19T23:54:30.554Z)
OS version: Windows_NT x64 10.0.18362
System Info
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
oop_rasterization: disabled_off
protected_video_decode: unavailable_off
rasterization: enabled
skia_renderer: disabled_off_ok
video_decode: enabled
viz_display_compositor: enabled_on
viz_hit_test_surface_layer: disabled_off_ok
webgl: enabled
webgl2: enabled
Extensions (17)
(3 theme extensions excluded)
The text was updated successfully, but these errors were encountered: