Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set DotNetCoreCLIV2 task's default verbosity input as Minimal #19850

Merged

Conversation

ivanduplenskikh
Copy link
Contributor

@ivanduplenskikh ivanduplenskikh commented May 8, 2024

Task name: DotNetCoreCLIV2

Description: verbosity input is set as Minimal (it is default value for dotnet restore command)
Related PR.
PR is recreated since the source repo was deleted.

Documentation changes required: N

Added unit tests: N

Attached related issue: #19848

Checklist:

  • Task version was bumped - please check instruction how to do it
  • Checked that applied changes work as expected

@ivanduplenskikh ivanduplenskikh requested review from DergachevE and a team as code owners May 8, 2024 12:15
@ivanduplenskikh ivanduplenskikh force-pushed the users/v-ivandu/change-DotNetCoreCLIV2-verbosity-level branch 2 times, most recently from b1cebf9 to bbafc9e Compare May 8, 2024 12:29
@cremor
Copy link

cremor commented May 8, 2024

You might also want to change verbosityPack at the same time.

@ivanduplenskikh ivanduplenskikh force-pushed the users/v-ivandu/change-DotNetCoreCLIV2-verbosity-level branch from 45eee04 to 1002826 Compare May 13, 2024 09:36
@martin-toman
Copy link
Contributor

Documentation changes required: N

The:
image

should be updated in the documentation, no?

https://learn.microsoft.com/en-us/azure/devops/pipelines/tasks/reference/dotnet-core-cli-v2?view=azure-pipelines#syntax

@cremor
Copy link

cremor commented May 13, 2024

Yes. And not only the green YAML code, but the text "Default value: Detailed." in the text below too.

@ivanduplenskikh
Copy link
Contributor Author

It looks like we don't need to update the documentation

@ivanduplenskikh ivanduplenskikh merged commit b56c747 into master May 13, 2024
11 checks passed
@ivanduplenskikh ivanduplenskikh deleted the users/v-ivandu/change-DotNetCoreCLIV2-verbosity-level branch May 13, 2024 13:21
@cremor
Copy link

cremor commented May 16, 2024

@ivanduplenskikh The documentation page was updated 2 days ago (after this PR was merged) but it still shows the old default values.

edit: Maybe this is because the updated task is not yet actually used in pipelines?

@steved0x
Copy link

@ivanduplenskikh The documentation page was updated 2 days ago (after this PR was merged) but it still shows the old default values.

edit: Maybe this is because the updated task is not yet actually used in pipelines?

There is a PR pending with the latest task updates in the documentation that includes the new default value and it should be live in a day or two. I run the tooling every 2 weeks and it picks up the changes from my test organization. I have been on vacation so there was a little bit of a break in running the tool.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[enhancement]: Change DotNetCoreCLI verbosityRestore defaultValue to Normal
8 participants