Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes the default verbosityRestore to be a more default value #12298

Closed
wants to merge 1 commit into from
Closed

Changes the default verbosityRestore to be a more default value #12298

wants to merge 1 commit into from

Conversation

aarondandy
Copy link
Contributor

This proposed change reduces the level of noise in the output from dotnet restore as outlined in #12297 . I am unable to run the build or tests on my machine so I hope this does not conflict with any possible regression tests 🤞

@bishal-pdMSFT
Copy link
Contributor

Thanks @aarondandy for the PR. I do not know of any reason why it should be detailed verbosity, and hence this looks good to me.
You will need to do two changes:

  1. Increment the task patch version.
  2. Make same changes in task.loc.json file as well. Ideally build would generate this file changes, but if you are not able to build locally then you can edit the file.

@msftclas
Copy link

msftclas commented Feb 5, 2020

CLA assistant check
All CLA requirements met.

@aarondandy
Copy link
Contributor Author

aarondandy commented Feb 5, 2020

I fixed the versions and duplicate files up as you requested. Also, I switched it from Normal to Minimal as that is the default for the dotnet tool according to both the docs and my testing.
The default for the dotnet restore tool is Minimal but as a compromise of reducing noise and providing helpful output we are going to go with Normal.

Docs: https://docs.microsoft.com/en-us/dotnet/core/tools/dotnet-restore#options

@bishal-pdMSFT
Copy link
Contributor

@aarondandy this PR needs to be synced base branch. Please do so and I will then merge it.

@aarondandy
Copy link
Contributor Author

@bishal-pdMSFT Can you double check that the patch increment is still correct? I am not familiar with how you version things in these PRs.

@aarondandy
Copy link
Contributor Author

I'm going to stop updating this PR to be up to date with master. Let me know before hand if you want to attempt merging this again and I can fix it up then. If you think this is not likely to be merged I can just close it.

@github-actions
Copy link

github-actions bot commented Dec 3, 2020

This PR is stale because it has been open for 180 days with no activity. Remove the stale label or comment on the PR otherwise this will be closed in 5 days

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants