Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Users/magleaso/unbreak publish radio check #18994

Merged
merged 11 commits into from
Sep 27, 2023
Merged

Users/magleaso/unbreak publish radio check #18994

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
592e6a3
Log more descriptive error message if version option input is invalid
magleaso Sep 6, 2023
cac1efb
Merge branch 'master' into users/magleaso/universalLogBadVersionInput…
magleaso Sep 7, 2023
c23c983
Run build, correct version strings
magleaso Sep 7, 2023
b492ec9
Merge branch 'master' into users/magleaso/unbreakPublishRadioCheck
magleaso Sep 19, 2023
0f66101
Fix check for publish version radio
magleaso Sep 19, 2023
0b308d7
Merge branch 'master' into users/magleaso/unbreakPublishRadioCheck
magleaso Sep 22, 2023
89441c9
Merge branch 'master' into users/magleaso/unbreakPublishRadioCheck
magleaso Sep 26, 2023
9ec7acd
Update task.loc.json 228 -> 229
magleaso Sep 26, 2023
3fa8e06
Update task.json 228 -> 229
magleaso Sep 26, 2023
b110f9a
Run build
magleaso Sep 26, 2023
36425b1
Merge branch 'master' into users/magleaso/unbreakPublishRadioCheck
magleaso Sep 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Tasks/UniversalPackagesV0/task.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
"category": "Package",
"version": {
"Major": 0,
"Minor": 228,
"Minor": 229,
"Patch": 0
},
"runsOn": [
Expand Down
2 changes: 1 addition & 1 deletion Tasks/UniversalPackagesV0/task.loc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
"category": "Package",
"version": {
"Major": 0,
"Minor": 228,
"Minor": 229,
"Patch": 0
},
"runsOn": [
Expand Down
2 changes: 1 addition & 1 deletion Tasks/UniversalPackagesV0/universalpublish.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ export async function run(artifactToolPath: string): Promise<void> {
if (versionRadio === "custom") {
version = tl.getInput("versionPublish");
}
else if (versionRadio in ["major", "minor", "patch"]) {
else if (["major", "minor", "patch"].includes(versionRadio.toLowerCase())) {
feedUri = await pkgLocationUtils.getFeedUriFromBaseServiceUri(serviceUri, accessToken);
version = await getNextPackageVersion(feedUri, accessToken, projectId, feedId, packageName);
} else {
Expand Down