Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Users/magleaso/unbreak publish radio check #18994

Merged
merged 11 commits into from
Sep 27, 2023
Merged

Users/magleaso/unbreak publish radio check #18994

merged 11 commits into from
Sep 27, 2023

Conversation

magleaso
Copy link
Contributor

@magleaso magleaso commented Sep 19, 2023 •
edited
Loading

Task name: upackv0

Description: Fix bug mentioned in #18975

Documentation changes required: N

Added unit tests: N

Attached related issue: Y

Checklist:

  • Task version was bumped - please check instruction how to do it
  • Checked that applied changes work as expected

@magleaso magleaso requested a review from a team as a code owner September 19, 2023 20:09
embetten
embetten approved these changes Sep 19, 2023
View reviewed changes
Copy link
Contributor

@embetten embetten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@magleaso
Copy link
Contributor Author

Tested by @zhenghao104

@magleaso magleaso merged commit 6df6724 into master Sep 27, 2023
@magleaso magleaso deleted the users/magleaso/unbreakPublishRadioCheck branch September 27, 2023 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DenisRumyantsev DenisRumyantsev DenisRumyantsev approved these changes

@embetten embetten embetten approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@magleaso @embetten @DenisRumyantsev