Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimizing the performance of CoveragePublisher for all scenarios #18281

Merged
merged 12 commits into from
Jun 9, 2023
Merged
Show file tree
Hide file tree
Changes from 7 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 3 additions & 8 deletions Tasks/Common/coveragepublisher/coveragepublisher.ts
Original file line number Diff line number Diff line change
Expand Up @@ -28,14 +28,9 @@ async function publishCoverage(inputFiles: string[], reportDirectory: string, pa
return false;
}

if (!dotnetPath && osvar === 'win32') {
// use full .NET to execute
dotnet = taskLib.tool(path.join(__dirname, 'CoveragePublisher', 'CoveragePublisher.Console.exe'));
} else {
dotnet = taskLib.tool(dotnetPath);
dotnet.arg(path.join(__dirname, "CoveragePublisher", 'CoveragePublisher.Console.dll'));
}

// use full .NET to execute
dotnet = taskLib.tool(path.join(__dirname, 'CoveragePublisher', 'CoveragePublisher.Console.exe'));
vinayakmsft marked this conversation as resolved.
Show resolved Hide resolved

dotnet.arg('"' + inputFiles.join('" "') + '"');
dotnet.arg('--reportDirectory ' + reportDirectory);

Expand Down
2 changes: 1 addition & 1 deletion Tasks/Common/coveragepublisher/make.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"externals": {
"archivePackages": [
{
"url": "https://coveragepublishers.blob.core.windows.net/coveragepublisher/19631413/CoveragePublisher.zip",
"url": "https://coveragepublishers.blob.core.windows.net/coveragepublisher/19806398/CoveragePublisher.zip",
"dest": "./"
}
]
Expand Down
2 changes: 1 addition & 1 deletion Tasks/PublishCodeCoverageResultsV2/task.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
"author": "Microsoft Corporation",
"version": {
"Major": 2,
"Minor": 221,
"Minor": 222,
"Patch": 0
},
"demands": [],
Expand Down
2 changes: 1 addition & 1 deletion Tasks/PublishCodeCoverageResultsV2/task.loc.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
"author": "Microsoft Corporation",
"version": {
"Major": 2,
"Minor": 221,
"Minor": 222,
"Patch": 0
},
"demands": [],
Expand Down