-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimizing the performance of CoveragePublisher for all scenarios #18281
Merged
vinayakmsft
merged 12 commits into
master
from
users/vinayakjoshi/OptimizeCoveragePublisher
Jun 9, 2023
Merged
Optimizing the performance of CoveragePublisher for all scenarios #18281
vinayakmsft
merged 12 commits into
master
from
users/vinayakjoshi/OptimizeCoveragePublisher
Jun 9, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakubch1
suggested changes
May 15, 2023
vinayakmsft
force-pushed
the
users/vinayakjoshi/OptimizeCoveragePublisher
branch
from
May 30, 2023 15:27
7b521b3
to
dc850b5
Compare
jakubch1
approved these changes
May 30, 2023
Approving based on Abhishek's comment |
adityashahms
approved these changes
Jun 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving based on Abhishek's Comments
@vinayakmsft Do we have a plan to deploy 223 version? |
Hi Chen,
The PR is merged , and the sprint deployments (ring wise) will begin from next to next week. So it would take 2-3 weeks for complete deployment.
From: ***@***.***>
Sent: 19 June 2023 10:50
To: ***@***.***>
Cc: Vinayak ***@***.***>; ***@***.***>
Subject: Re: [microsoft/azure-pipelines-tasks] Optimizing the performance of CoveragePublisher for all scenarios (PR #18281)
@vinayakmsft<https://github.com/vinayakmsft> Do we have a plan to deploy 223 version?
—
Reply to this email directly, view it on GitHub<#18281 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/A2JXGR32YP6F7EPKZB5WDZ3XL7OPTANCNFSM6AAAAAAYBEBG6Q>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Thanks for quick reply @vinayakmsft , and any idea or workaroud before the deployment? |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task name: PublishCodeCoverageResults V2
Description: Publish Code Coverage Results V2 task uses the CoveragePublisher package. We use the CovereagePublisher.Console.exe which can perform all the tasks of the PublishCodeCoverageV2 task after the .net core upgrade. It is a selft contained file and is optimized. This exe runs without having to install the .net core sdk versions. There is no need to have the .dll file mentioned in the Coveragepublisher.ts file.
Similarly we enabled the task for Linux and macos agent. So now the PCCRV2 task will be supported on the Linux and macos agents as well without having to install .net core sdk tasks.
Documentation changes required: (Y/N) Y.
Local testing: Working correctly as expected.
Few pipelines tests on linux, windows and macos agents covering all the scenarios:
Windows agents:
Pipelines - Run 204 (azure.com)
Macos agent - https://dev.azure.com/ForCjson/cjsontask/_build/results?buildId=210&view=results
Linux/ubuntu agent - https://dev.azure.com/ForCjson/cjsontask/_build/results?buildId=211&view=results
Pipeline for testing:
Results:
Checklist: