Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimizing the performance of CoveragePublisher for all scenarios #18281

Merged
merged 12 commits into from
Jun 9, 2023

Conversation

vinayakmsft
Copy link
Contributor

@vinayakmsft vinayakmsft commented May 14, 2023

Task name: PublishCodeCoverageResults V2

Description: Publish Code Coverage Results V2 task uses the CoveragePublisher package. We use the CovereagePublisher.Console.exe which can perform all the tasks of the PublishCodeCoverageV2 task after the .net core upgrade. It is a selft contained file and is optimized. This exe runs without having to install the .net core sdk versions. There is no need to have the .dll file mentioned in the Coveragepublisher.ts file.

Similarly we enabled the task for Linux and macos agent. So now the PCCRV2 task will be supported on the Linux and macos agents as well without having to install .net core sdk tasks.

Documentation changes required: (Y/N) Y.

Local testing: Working correctly as expected.

Few pipelines tests on linux, windows and macos agents covering all the scenarios:

  1. Windows agents:
    Pipelines - Run 204 (azure.com)

  2. Macos agent - https://dev.azure.com/ForCjson/cjsontask/_build/results?buildId=210&view=results

  3. Linux/ubuntu agent - https://dev.azure.com/ForCjson/cjsontask/_build/results?buildId=211&view=results

Pipeline for testing:
image

Results:

image

Checklist:

  • Task version was bumped - please check instruction how to do it
  • Checked that applied changes work as expected

@vinayakmsft vinayakmsft force-pushed the users/vinayakjoshi/OptimizeCoveragePublisher branch from 7b521b3 to dc850b5 Compare May 30, 2023 15:27
@vinayakmsft vinayakmsft requested a review from adityashahms June 9, 2023 10:27
@adityashahms
Copy link
Contributor

Approving based on Abhishek's comment

@adityashahms adityashahms reopened this Jun 9, 2023
Copy link
Contributor

@adityashahms adityashahms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving based on Abhishek's Comments

@chenlish
Copy link

@vinayakmsft Do we have a plan to deploy 223 version?

@vinayakmsft
Copy link
Contributor Author

vinayakmsft commented Jun 19, 2023 via email

@chenlish
Copy link

Thanks for quick reply @vinayakmsft , and any idea or workaroud before the deployment?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants