Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Maven V3] Fixed input string to boolean type for JUnitTestsResult field #15364

Merged
merged 6 commits into from
Oct 7, 2021
Merged

[Maven V3] Fixed input string to boolean type for JUnitTestsResult field #15364

merged 6 commits into from
Oct 7, 2021

Conversation

AlexanderBadalov
Copy link
Contributor

@AlexanderBadalov AlexanderBadalov commented Oct 3, 2021 •
edited
Loading

Task name: MavenV3

Description: Changed input type for publishJunitTests parameter from string to boolean

Documentation changes required: (Y/N) N

Added unit tests: (Y/N) N

Attached related issue: (Y/N) #15060

Checklist:

  • Task version was bumped - please check instruction how to do it
  • Checked that applied changes work as expected

@AlexanderBadalov AlexanderBadalov marked this pull request as ready for review October 4, 2021 15:09
@AlexanderBadalov AlexanderBadalov requested a review from a team as a code owner October 4, 2021 15:09
@ghost
Copy link

ghost commented Oct 4, 2021 •
edited by ghost
Loading

CLA assistant check
All CLA requirements met.

@DaniilShmelev DaniilShmelev requested a review from a team October 4, 2021 16:24
@AlexanderBadalov AlexanderBadalov changed the title Fixed #15060 [Maven V3] Fixed input type for JUnitTests #15060 Oct 4, 2021
@AlexanderBadalov AlexanderBadalov changed the title [Maven V3] Fixed input type for JUnitTests #15060 [Maven V3] Fixed input string to boolean type for JUnitTestsResult field #15060 Oct 4, 2021
@AlexanderBadalov AlexanderBadalov changed the title [Maven V3] Fixed input string to boolean type for JUnitTestsResult field #15060 [Maven V3] Fixed input string to boolean type for JUnitTestsResult field Oct 4, 2021
@AlexanderBadalov
Copy link
Contributor Author

image
With the following input result before was
image
After fix
image

@AlexanderBadalov AlexanderBadalov merged commit 44c79b3 into microsoft:master Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaniilShmelev DaniilShmelev DaniilShmelev approved these changes

@anatolybolshakov anatolybolshakov anatolybolshakov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlexanderBadalov @anatolybolshakov @DaniilShmelev