Skip to content

Commit

Permalink
[Maven V3] Fixed input string to boolean type for JUnitTestsResult fi…
Browse files Browse the repository at this point in the history
…eld (#15364)

* fixed publishJunitType

* Changed publish type

* Fixed comparison

* Changed minor version

Co-authored-by: Maxim Zaytsev <v-mazayt@microsoft.com>
  • Loading branch information
AlexanderBadalov and Maxim Zaytsev authored Oct 7, 2021
1 parent 40780fd commit 44c79b3
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions Tasks/MavenV3/maventask.ts
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ var javaHomeSelection: string = tl.getInput('javaHomeSelection', true);
var mavenVersionSelection: string = tl.getInput('mavenVersionSelection', true);
var mavenGoals: string[] = tl.getDelimitedInput('goals', ' ', true); // This assumes that goals cannot contain spaces
var mavenOptions: string = tl.getInput('options', false); // Options can have spaces and quotes so we need to treat this as one string and not try to parse it
var publishJUnitResults: string = tl.getInput('publishJUnitResults');
var publishJUnitResults: boolean = tl.getBoolInput('publishJUnitResults');
var testResultsFiles: string = tl.getInput('testResultsFiles', true);
var ccTool = tl.getInput('codeCoverageTool');
var authenticateFeed = tl.getBoolInput('mavenFeedAuthenticate', true);
Expand Down Expand Up @@ -278,7 +278,7 @@ async function execBuild() {
})
.then(function () {
// 5. Always publish test results even if tests fail, causing this task to fail.
if (publishJUnitResults == 'true') {
if (publishJUnitResults === true) {
publishJUnitTestResults(testResultsFiles);
}
publishCodeCoverage(isCodeCoverageOpted).then(function() {
Expand Down
2 changes: 1 addition & 1 deletion Tasks/MavenV3/task.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
"author": "Microsoft Corporation",
"version": {
"Major": 3,
"Minor": 193,
"Minor": 194,
"Patch": 0
},
"releaseNotes": "Configuration of the SonarQube analysis was moved to the [SonarQube](https://marketplace.visualstudio.com/items?itemName=SonarSource.sonarqube) or [SonarCloud](https://marketplace.visualstudio.com/items?itemName=SonarSource.sonarcloud) extensions, in task `Prepare Analysis Configuration`",
Expand Down
2 changes: 1 addition & 1 deletion Tasks/MavenV3/task.loc.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
"author": "Microsoft Corporation",
"version": {
"Major": 3,
"Minor": 193,
"Minor": 194,
"Patch": 0
},
"releaseNotes": "ms-resource:loc.releaseNotes",
Expand Down

0 comments on commit 44c79b3

Please sign in to comment.