Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Encode only when decode is true #14946

Merged
merged 1 commit into from
Jun 8, 2021
Merged

Encode only when decode is true #14946

merged 1 commit into from
Jun 8, 2021

Conversation

tauhid621
Copy link
Contributor

@tauhid621 tauhid621 commented Jun 8, 2021 •
edited
Loading

Task name: AzureKeyVaultV2

Description: Task was encoding variables even when decode variable was set as false.

Documentation changes required: (Y/N) N

Added unit tests: (Y/N) Y

Attached related issue: (Y/N) #14942

Checklist:

  • Task version was bumped - please check instruction how to do it
  • Checked that applied changes work as expected

@tauhid621 tauhid621 requested a review from rohit-batra as a code owner June 8, 2021 06:15
@tauhid621 tauhid621 requested a review from thesattiraju June 8, 2021 06:15
@tauhid621 tauhid621 linked an issue Jun 8, 2021 that may be closed by this pull request
AzureKeyVaultV2 task should not always encode percents #14942
Closed
@tauhid621 tauhid621 merged commit 45b7ed6 into master Jun 8, 2021
@tauhid621 tauhid621 mentioned this pull request Jun 9, 2021
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thesattiraju thesattiraju thesattiraju approved these changes

@rohit-batra rohit-batra Awaiting requested review from rohit-batra

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AzureKeyVaultV2 task should not always encode percents
2 participants
@tauhid621 @thesattiraju