Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AzureKeyVaultV2 task should not always encode percents #14942

Closed
tejasd1990 opened this issue Jun 8, 2021 · 0 comments · Fixed by #14946
Closed

AzureKeyVaultV2 task should not always encode percents #14942

tejasd1990 opened this issue Jun 8, 2021 · 0 comments · Fixed by #14946

Comments

@tejasd1990
Copy link
Contributor

Note

Issues in this repo are for tracking bugs, feature requests and questions for the tasks in this repo

For a list:
https://github.com/Microsoft/azure-pipelines-tasks/tree/master/Tasks

If you have an issue or request for the Azure Pipelines service, use developer community instead:

https://developercommunity.visualstudio.com/spaces/21/index.html )

Required Information

Entering this information will route you directly to the right team and expedite traction.

Question, Bug, or Feature?
Bug

Enter Task Name: AzureKeyVaultV2

list here (V# not needed):
https://github.com/Microsoft/azure-pipelines-tasks/tree/master/Tasks

Environment

  • Server - Azure Pipelines or TFS on-premises?
    NA

  • Agent - Hosted or Private:
    NA

Issue Description

the task always encodes % to %AZP25 while setting the secrets as pipeline variables. This is wrong if DECODE_PERCENTS has been explicitly set to false in the pipeline, since when the agent reads the values for subsequent tasks, it won't decode %AZP25 back to %. This encoding should be done based on the condition that DECODE_PERCENTS is not false, it can be true, or not set(which defaults to true)

Task logs

[Enable debug logging and please provide the zip file containing all the logs for a speedy resolution]

Troubleshooting

Checkout how to troubleshoot failures and collect debug logs: https://docs.microsoft.com/en-us/vsts/build-release/actions/troubleshooting

Error logs

[Insert error from the logs here for a quick overview]

@tauhid621 tauhid621 linked a pull request Jun 8, 2021 that will close this issue
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant