Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use mc-fus in AppCenterDistributeV2 #13353

Merged
merged 2 commits into from
Jul 28, 2020

Conversation

annakocheshkova
Copy link

Task name: AppCenterDistributeV2

Description: This PR will change the logic behind file uploading - it will add implementation of File Upload Service library (copied as source code).

Documentation changes required: (Y/N) N

Added unit tests: (Y/N) Y

Attached related issue: (Y/N) AB#81398

Checklist:

  • Task version was bumped - please check instruction how to do it
  • Checked that applied changes work as expected

Copy link

@damccorm damccorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't say much about content here because I'm not very familiar with this task or the libraries involved, but this did get a lot of review action in the previous iteration #13204

From a general task standpoint I'm comfortable approving

@damccorm damccorm merged commit 17d3731 into microsoft:master Jul 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants