Use MC FUS library in AppCenterDistribute tasks #13204
Conversation
…shkova/azure-pipelines-tasks into feature-mc-fus-v3-unit
…nal-library Remove mc-fus library code and import it from local repository.
|
For all the reviewers: I don't have the permissions to resolve comments. |
|
Howdy @microsoft/akvelon-build-task-team! Thanks for handling this one. @annakocheshkova please continue working with @anatolybolshakov |
|
Could you please add e2e tests also to cover these cases? There's no e2e tests for appcenter task at all at the moment, and I think it is still risky to apply such major changes without them |
| clearInterval(timerId); | ||
| defer.reject(new Error(`Loading release id failed: ${response ? response.error_details : ''}`)); | ||
| } | ||
| }, 2000); |
There was a problem hiding this comment.
Could you please move this to constants?
|
@zachariahcox could you please take a look also and approve if it's looks good for you? |
|
@damccorm @stephenmichaelf can one of you gentlemen review this when you get a chance? Thanks! |
|
This change is pretty massive (90 files!) and seems to be doing several things. Notably, upgrading the task-lib is introducing a lot of churn here. Can we break this PR apart into 2 PRs that are a little more manageable. I think upgrading the task-lib plus some of the test/style changes probably deserve a review on their own. Could you also please motivate why this is necessary? This seems pretty high risk. Do we need it in all 3 versions of the task, or is it good enough to just update the most recent version? |
Task name: Use MC FUS library in AppCenterDistribute tasks (V1, V2, V3)
Description: This PR will change the logic behind file uploading - it will add implementation of File Upload Service library (copied as source code).
Documentation changes required: (Y/N) N
Added unit tests: (Y/N) Y (unit tests changed, fixed)
Attached related issue: (Y/N) N
AB#81398
Checklist: