Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated error message to be actionable for no web project found. #10677

Merged
merged 3 commits into from
Jun 20, 2019
Merged

updated error message to be actionable for no web project found. #10677

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
90ca1ae
updated error message to be actionable for no web project found.
hiyadav Jun 18, 2019
b22ea18
updated error message as per PR comment.
hiyadav Jun 20, 2019
24d7c44
Merge branch 'master' into users/hiyada/dotNetCoreCLiErrorMessage
hiyadav Jun 20, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Tasks/DotNetCoreCLIV2/Strings/resources.resjson/en-US/resources.resjson
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@
"loc.messages.dotnetCommandFailed": "Dotnet command failed with non-zero exit code on the following projects : %s",
"loc.messages.noProjectFilesFound": "Project file(s) matching the specified pattern were not found.",
"loc.messages.noPublishFolderFoundToZip": "A publish folder could not be found to zip for project file: %s.",
"loc.messages.noWebProjctFound": "No web project was found in the repository. Web projects are identified by presence of either a web.config file or wwwroot folder in the directory.",
"loc.messages.noWebProjectFound": "No web project was found in the repository. Web projects are identified by presence of either a web.config file or wwwroot folder in the directory. You can set Publish Web Projects property to false (publishWebProjects: false in yml) if your project doesn't follow this convention or if you want to publish projects other than web projects.",
"loc.messages.zipFailed": "Zip failed with error: %s",
"loc.messages.Error_ApiKeyNotSupported": "DotNetCore currently does not support using an encrypted Api Key.",
"loc.messages.Error_ExpectedConfigurationElement": "Invalid xml. Expected element named 'configuration'.",
Expand Down
4 changes: 2 additions & 2 deletions Tasks/DotNetCoreCLIV2/dotnetcore.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,7 +250,7 @@ export class dotNetExe {
}

private extractOutputArgument(): void {
if (!this.arguments || !this.arguments.trim()) {
if (!this.arguments || !this.arguments.trim()) {
return;
}

Expand Down Expand Up @@ -334,7 +334,7 @@ export class dotNetExe {
});

if (!projectFiles.length) {
tl.error(tl.loc("noWebProjctFound"));
tl.error(tl.loc("noWebProjectFound"));
}
}

Expand Down
6 changes: 3 additions & 3 deletions Tasks/DotNetCoreCLIV2/task.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"version": {
"Major": 2,
"Minor": 154,
"Patch": 3
"Patch": 4
},
"minimumAgentVersion": "2.115.0",
"instanceNameFormat": "dotnet $(command)",
Expand Down Expand Up @@ -529,7 +529,7 @@
"dotnetCommandFailed": "Dotnet command failed with non-zero exit code on the following projects : %s",
"noProjectFilesFound": "Project file(s) matching the specified pattern were not found.",
"noPublishFolderFoundToZip": "A publish folder could not be found to zip for project file: %s.",
"noWebProjctFound": "No web project was found in the repository. Web projects are identified by presence of either a web.config file or wwwroot folder in the directory.",
"noWebProjectFound": "No web project was found in the repository. Web projects are identified by presence of either a web.config file or wwwroot folder in the directory. You can set Publish Web Projects property to false (publishWebProjects: false in yml) if your project doesn't follow this convention or if you want to publish projects other than web projects.",
"zipFailed": "Zip failed with error: %s",
"Error_ApiKeyNotSupported": "DotNetCore currently does not support using an encrypted Api Key.",
"Error_ExpectedConfigurationElement": "Invalid xml. Expected element named 'configuration'.",
Expand Down Expand Up @@ -559,4 +559,4 @@
"Warning_SessionCreationFailed": "Could not create provenance session: %s",
"Warning_UpdatingNuGetVersion": "Updating version of NuGet.exe to %s from %s. Behavior changes or breaking changes might occur as NuGet updates to a new version. If this is not desired, deselect the 'Check for Latest Version' option in the task."
}
}
}
4 changes: 2 additions & 2 deletions Tasks/DotNetCoreCLIV2/task.loc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"version": {
"Major": 2,
"Minor": 154,
"Patch": 3
"Patch": 4
},
"minimumAgentVersion": "2.115.0",
"instanceNameFormat": "ms-resource:loc.instanceNameFormat",
Expand Down Expand Up @@ -529,7 +529,7 @@
"dotnetCommandFailed": "ms-resource:loc.messages.dotnetCommandFailed",
"noProjectFilesFound": "ms-resource:loc.messages.noProjectFilesFound",
"noPublishFolderFoundToZip": "ms-resource:loc.messages.noPublishFolderFoundToZip",
"noWebProjctFound": "ms-resource:loc.messages.noWebProjctFound",
"noWebProjectFound": "ms-resource:loc.messages.noWebProjectFound",
"zipFailed": "ms-resource:loc.messages.zipFailed",
"Error_ApiKeyNotSupported": "ms-resource:loc.messages.Error_ApiKeyNotSupported",
"Error_ExpectedConfigurationElement": "ms-resource:loc.messages.Error_ExpectedConfigurationElement",
Expand Down