Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated error message to be actionable for no web project found. #10677

Merged
merged 3 commits into from
Jun 20, 2019

Conversation

hiyadav
Copy link
Contributor

@hiyadav hiyadav commented Jun 18, 2019

@hiyadav hiyadav requested review from issacnitin and sachinma June 18, 2019 07:03
@@ -103,7 +103,7 @@
"loc.messages.dotnetCommandFailed": "Dotnet command failed with non-zero exit code on the following projects : %s",
"loc.messages.noProjectFilesFound": "Project file(s) matching the specified pattern were not found.",
"loc.messages.noPublishFolderFoundToZip": "A publish folder could not be found to zip for project file: %s.",
"loc.messages.noWebProjctFound": "No web project was found in the repository. Web projects are identified by presence of either a web.config file or wwwroot folder in the directory.",
"loc.messages.noWebProjectFound": "No web project was found in the repository. Web projects are identified by presence of either a web.config file or wwwroot folder in the directory. You can uncheck `Publish Web Projects` if your project doesn't follow the aforementioned web project criteria.",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can set Publish Web Projects property to false (publishWebProjects: false in yml) if your project doesn't following this convention or if you want to publish projects other than web projects.

@hiyadav hiyadav merged commit 5e929f9 into master Jun 20, 2019
@hiyadav hiyadav deleted the users/hiyada/dotNetCoreCLiErrorMessage branch June 20, 2019 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants