Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MddGetPackageGraphRevisionId() + M.W.AM.DynamicDependency.PackageDependency.PackageGraphRevisionId API Spec #2898

Merged
merged 2 commits into from
Oct 4, 2022
Merged

Add MddGetPackageGraphRevisionId() + M.W.AM.DynamicDependency.PackageDependency.PackageGraphRevisionId API Spec #2898

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
db6c6ea
Updated spec (missing changes per previous API Review). Added contact…
DrusTheAxe Aug 23, 2022
a120c96
Merge branch 'main' into user/drustheaxe/dyndep-revisionid-spec
DrusTheAxe Aug 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 23 additions & 7 deletions specs/dynamicdependencies/DynamicDependencies.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1253,7 +1253,13 @@ STDAPI MddGetIdForPackageDependencyContext(
_In_ MDD_PACKAGEDEPENDENCY_CONTEXT packageDependencyContext,
_Outptr_result_maybenull_ PWSTR* packageDependencyId) noexcept;

/// Return the package graph's current generation id.
/// Return the package graph's current revision id.
STDAPI_(UINT32) MddGetPackageGraphRevisionId() noexcept;

/// Return the package graph's current revision id.
///
/// @note This API is deprecated and will be removed in a future release.
/// Use MddGetPackageGraphRevisionId().
STDAPI_(UINT32) MddGetGenerationId() noexcept;
```

Expand Down Expand Up @@ -1565,6 +1571,9 @@ namespace Microsoft.Windows.ApplicationModel.DynamicDependency
```c# (but really MIDL3)
namespace Microsoft.Windows.ApplicationModel.DynamicDependency
{
[contractversion(2)]
apicontract DynamicDependencyContract{};

/// CPU architectures to optionally filter available packages against a package dependency.
/// These generally correspond to processor architecture types supported by MSIX.
/// @see Windows.System.ProcessorArchitecture
Expand Down Expand Up @@ -1802,9 +1811,9 @@ runtimeclass PackageDependency
/// Calls to Add() can be balanced by a PackageDependencyContext.Remove()
/// to remove the entry from the package graph.
///
/// Successful calls change the package graph's current generation id.
/// Successful calls change the package graph's current revision id.
///
/// @see GenerationId
/// @see PackageGraphRevisionId
PackageDependencyContext Add();

/// Resolve a previously pinned PackageDependency to a specific package and
Expand Down Expand Up @@ -1841,12 +1850,19 @@ runtimeclass PackageDependency
/// Calls to Add() can be balanced by a PackageDependencyContext.Remove() (or object destruction)
/// to remove the entry from the package graph.
///
/// Successful calls change the package graph's current generation id.
/// Successful calls change the package graph's current revision id.
///
/// @see GenerationId
/// @see PackageGraphRevisionId
PackageDependencyContext Add(AddPackageDependencyOptions options);

/// Return the package graph's current generation id.
/// Return the package graph's current revision id.
[contract(DynamicDependencyContract, 2)]
static UInt32 PackageGraphRevisionId{ get; };
DrusTheAxe marked this conversation as resolved.
Show resolved Hide resolved

/// Return the package graph's current revision id.
///
/// @note This API is deprecated and will be removed in a future release.
/// Use the PackageGraphRevisionId property.
static UInt32 GenerationId{ get; };
};

Expand Down Expand Up @@ -1886,7 +1902,7 @@ runtimeclass PackageDependencyContext
///
/// Successful calls change the package graph's current revision id.
///
/// @see PackageDependency.GenerationId
/// @see PackageDependency.RevisionId
void Remove();
};
}
Expand Down