-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MddGetPackageGraphRevisionId() + M.W.AM.DynamicDependency.PackageDependency.PackageGraphRevisionId API Spec #2898
Conversation
…s (added in WinAppSDK 1.1). Added PackageGraphRevisionId, for alignment with Windows API (GenerationId is soft-deprecated; will go away in a future release)
We're doing an "email review" of this - please leave your comments in the PR by 5pm Seattle time, 2022-08-26. @DrusTheAxe will address feedback in future updates. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it on purpose that we change generation => revision id but make no mention of the "soft deprecation?"
Are you referring to a specific line? |
No, it seems like most of the edits just change generation => revision. But no mention is made of what you're supposed to do if you had previously used generation. I'm not asking for a change here necessarily, just wondering if silently doing a "replace" here is what you intended / OK. |
2 words for the same thing. Was originally called GenerationId in Windows (internal) and then WinAppSDK DynDep API Review. Windows had no public API to get that value so we fixed that with a new public API ( This merely updates WinAppSDK to support consist lingo with Windows. Compat's retained for now; breaking changes deferred to vFuture when that's viable e.g. 2.0
Yes. Given it's the same thing, the GetGeneration doc-comments point you to GetRevision, and it's open source so anyone who looks can see it's the same thing1 I didn't see a need to belabor the point. I expect the release notes and docs will mention this. 1 The implementation is literally 1-liners |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Add
MddGetPackageGraphRevisionId()
(Flat-C API) andPackageGraphRevisionId
property (WinRT API), for alignment with Windows 11 API / terminology.GenerationId is soft-deprecated (predecessor equivalent to PackageGraphRevisionId still supported but will go away in a future release).
Also corrected spec missing updates:
https://task.ms/41077950