Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert string enum changes #16569

Merged
merged 6 commits into from
Jun 15, 2017
Merged

Revert string enum changes #16569

merged 6 commits into from
Jun 15, 2017

Commits on Jun 15, 2017

  1. Revert "Convert Extension to a string enum (#16425)" 

    This reverts commit 09321b3.
    @mhegazy
    mhegazy committed Jun 15, 2017
    Configuration menu
    Copy the full SHA
    8b87d79 View commit details
    Browse the repository at this point in the history

  2. Revert "Also convert ClassificationTypeNames and CommandTypes/Command… 

    …Names"

This reverts commit f94818d.
    @mhegazy
    mhegazy committed Jun 15, 2017
    Configuration menu
    Copy the full SHA
    e4fa5f2 View commit details
    Browse the repository at this point in the history

  3. Revert "Make ScriptElementKind and HighlightSpanKind string enums" 

    This reverts commit b162097.
    @mhegazy
    mhegazy committed Jun 15, 2017
    Configuration menu
    Copy the full SHA
    57df9ad View commit details
    Browse the repository at this point in the history

  4. Revert "Make ScriptElementKind and HighlightSpanKind string enums" 

    This reverts commit b162097.

# Conflicts:
#	lib/lib.d.ts
#	lib/lib.es2016.full.d.ts
#	lib/lib.es2017.full.d.ts
#	lib/lib.es5.d.ts
#	lib/lib.es6.d.ts
#	lib/lib.esnext.full.d.ts
#	lib/tsc.js
#	lib/tsserver.js
#	lib/tsserverlibrary.d.ts
#	lib/tsserverlibrary.js
#	lib/typescript.d.ts
#	lib/typescript.js
#	lib/typescriptServices.d.ts
#	lib/typescriptServices.js
#	lib/typingsInstaller.js
    @mhegazy
    Andy Hanson authored and mhegazy committed Jun 15, 2017
    Configuration menu
    Copy the full SHA
    09c9f1e View commit details
    Browse the repository at this point in the history

  5. Update LKG

    @mhegazy
    mhegazy committed Jun 15, 2017
    Configuration menu
    Copy the full SHA
    2137bbf View commit details
    Browse the repository at this point in the history

  6. Revert "Make CommandTypes a const enum and use allCommandTypes for … 

    …unit test"

This reverts commit f6240cb.
    @mhegazy
    mhegazy committed Jun 15, 2017
    Configuration menu
    Copy the full SHA
    dd3d485 View commit details
    Browse the repository at this point in the history