Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert Extension to a string enum #16425

Merged
1 commit merged into from
Jun 10, 2017
Merged

Convert Extension to a string enum #16425

1 commit merged into from
Jun 10, 2017

Conversation

ghost
Copy link

@ghost ghost commented Jun 9, 2017

This should be backwards-compatible so long as people are accessing it as Extension.Ts and not 0.

@ghost ghost merged commit 09321b3 into master Jun 10, 2017
@ghost ghost deleted the extension branch June 10, 2017 02:32
@mhegazy mhegazy added API Relates to the public API for TypeScript Breaking Change Would introduce errors in existing code labels Jun 10, 2017
@mhegazy mhegazy added this to the TypeScript 2.4 milestone Jun 10, 2017
@mhegazy
Copy link
Contributor

mhegazy commented Jun 10, 2017

@andy-ms please add a note about this change and the other namespace -> string enum changes in https://github.com/Microsoft/TypeScript/wiki/API-Breaking-Changes

@ghost
Copy link
Author

ghost commented Jun 12, 2017

@mhegazy Done.

mhegazy added a commit that referenced this pull request Jun 15, 2017
mhegazy added a commit that referenced this pull request Jun 15, 2017
* Revert "Convert Extension to a string enum (#16425)"

This reverts commit 09321b3.

* Revert "Also convert ClassificationTypeNames and CommandTypes/CommandNames"

This reverts commit f94818d.

* Revert "Make ScriptElementKind and HighlightSpanKind string enums"

This reverts commit b162097.

* Revert "Make ScriptElementKind and HighlightSpanKind string enums"

This reverts commit b162097.

# Conflicts:
#	lib/lib.d.ts
#	lib/lib.es2016.full.d.ts
#	lib/lib.es2017.full.d.ts
#	lib/lib.es5.d.ts
#	lib/lib.es6.d.ts
#	lib/lib.esnext.full.d.ts
#	lib/tsc.js
#	lib/tsserver.js
#	lib/tsserverlibrary.d.ts
#	lib/tsserverlibrary.js
#	lib/typescript.d.ts
#	lib/typescript.js
#	lib/typescriptServices.d.ts
#	lib/typescriptServices.js
#	lib/typingsInstaller.js

* Update LKG

* Revert "Make CommandTypes a const enum and use `allCommandTypes` for unit test"

This reverts commit f6240cb.
@microsoft microsoft locked and limited conversation to collaborators Jun 14, 2018
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
API Relates to the public API for TypeScript Breaking Change Would introduce errors in existing code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants