Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No suggestions for string literal types when using an empty template string #19162

Closed
mjbvz opened this issue Oct 13, 2017 · 0 comments
Closed

No suggestions for string literal types when using an empty template string #19162

mjbvz opened this issue Oct 13, 2017 · 0 comments
Labels
Bug A bug in TypeScript Domain: Completion Lists The issue relates to showing completion lists in an editor Fixed A PR has been merged for this issue Good First Issue Well scoped, documented and has the green light Help Wanted You can do this VS Code Tracked There is a VS Code equivalent to this issue
Milestone
TypeScript 2.7

Comments

@mjbvz
Copy link
Contributor

mjbvz commented Oct 13, 2017 •
edited
Loading

From microsoft/vscode#36161

TypeScript Version: 2.6.0-20171013

Code

let count: 'one' | 'two';
count = `|`

Request auto complete at the |

Expected behavior:
Returns entries for 'one' and 'two'

Actual behavior:
No entries returned.

We see the correct behavior if you use single or double quotes:

screen shot 2017-10-13 at 10 17 27 am
@mjbvz mjbvz added the VS Code Tracked There is a VS Code equivalent to this issue label Oct 13, 2017
@mjbvz mjbvz mentioned this issue Oct 13, 2017
Closed
@mhegazy mhegazy added Bug A bug in TypeScript Help Wanted You can do this Good First Issue Well scoped, documented and has the green light labels Oct 14, 2017
@mhegazy mhegazy added this to the Community milestone Oct 14, 2017
@mhegazy mhegazy added the Domain: Completion Lists The issue relates to showing completion lists in an editor label Oct 14, 2017
Kingwl added a commit to Kingwl/TypeScript that referenced this issue Oct 16, 2017
@Kingwl
fix completions for string literal types with template string (micro…
70dae96 
…soft#19162)
@Kingwl Kingwl mentioned this issue Oct 16, 2017
Merged
Kingwl added a commit to Kingwl/TypeScript that referenced this issue Nov 10, 2017
@Kingwl
fix completions for string literal types with template string (micro…
f1904a9 
…soft#19162)
@DanielRosenwasser DanielRosenwasser added the Fixed A PR has been merged for this issue label Dec 19, 2017
@DanielRosenwasser DanielRosenwasser modified the milestones: Community, TypeScript 2.7 Dec 19, 2017
DanielRosenwasser added a commit that referenced this issue Dec 19, 2017
@DanielRosenwasser
Merge pull request #19204 from Kingwl/fix-completions-with-template-l…
89b5d8c 
…iteral-type

 fix completions for string literal types with template string (#19162)
@microsoft microsoft locked and limited conversation to collaborators Jun 21, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Bug A bug in TypeScript Domain: Completion Lists The issue relates to showing completion lists in an editor Fixed A PR has been merged for this issue Good First Issue Well scoped, documented and has the green light Help Wanted You can do this VS Code Tracked There is a VS Code equivalent to this issue
Projects
None yet
Milestone
TypeScript 2.7
Development

No branches or pull requests
3 participants
@DanielRosenwasser @mhegazy @mjbvz