Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript autocomplete string inside backticks #36161

Closed
usernamehw opened this issue Oct 12, 2017 · 4 comments
Closed

Typescript autocomplete string inside backticks #36161

usernamehw opened this issue Oct 12, 2017 · 4 comments
Assignees
Labels
typescript Typescript support issues upstream Issue identified as 'upstream' component related (exists outside of VS Code)

Comments

@usernamehw
Copy link
Contributor

usernamehw commented Oct 12, 2017

let count: 'one' | 'two';

When using single quote or double quote autocomplete works:

count = '|';
count = "|";

But not for backticks:

count = `|`;

Also, wouldn't it be better when having a definite set of strings (here 'one' & 'two') trigger autocomplete on typing opening quote?

@vscodebot vscodebot bot added the typescript Typescript support issues label Oct 12, 2017
@usernamehw
Copy link
Contributor Author

As I now see it's currently not possible to auto trigger by typing quote 25 034 issue.

@usernamehw usernamehw changed the title Typescript autocomplete string inside template literal Typescript autocomplete string inside backticks Oct 12, 2017
@mjbvz mjbvz added the *duplicate Issue identified as a duplicate of another issue(s) label Oct 12, 2017
@mjbvz
Copy link
Collaborator

mjbvz commented Oct 12, 2017

Yes this is a duplicate of #25034

@mjbvz mjbvz closed this as completed Oct 12, 2017
@usernamehw
Copy link
Contributor Author

@mjbvz The crux of the matter was that there is no autocomplete inside backticks:

let count: 'one' | 'two';
// // put the cursor inside quotes
count = ``;// trigger autocomplete

@mjbvz
Copy link
Collaborator

mjbvz commented Oct 13, 2017

Thanks. Opened microsoft/TypeScript#19162 to track this upstream

@mjbvz mjbvz added upstream Issue identified as 'upstream' component related (exists outside of VS Code) and removed *duplicate Issue identified as a duplicate of another issue(s) labels Oct 13, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 26, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
typescript Typescript support issues upstream Issue identified as 'upstream' component related (exists outside of VS Code)
Projects
None yet
Development

No branches or pull requests

2 participants