Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean our repo before running CI #526

Merged
merged 1 commit into from
Feb 25, 2020

Conversation

barcharcraz
Copy link
Member

@barcharcraz barcharcraz commented Feb 25, 2020

Description

tell azure pipelines to clean our repo before building, to prevent badness and broken CI pipelines.

This is a workaround for #396

Checklist

Be sure you've read README.md and understand the scope of this repo.

If you're unsure about a box, leave it unchecked. A maintainer will help you.

  • Identifiers in product code changes are properly _Ugly as per
    https://eel.is/c++draft/lex.name#3.1 or there are no product code changes.
  • The STL builds successfully and all tests have passed (must be manually
    verified by an STL maintainer before automated testing is enabled on GitHub,
    leave this unchecked for initial submission).
  • These changes introduce no known ABI breaks (adding members, renaming
    members, adding virtual functions, changing whether a type is an aggregate
    or trivially copyable, etc.).
  • These changes were written from scratch using only this repository,
    the C++ Working Draft (including any cited standards), other WG21 papers
    (excluding reference implementations outside of proposed standard wording),
    and LWG issues as reference material. If they were derived from a project
    that's already listed in NOTICE.txt, that's fine, but please mention it.
    If they were derived from any other project (including Boost and libc++,
    which are not yet listed in NOTICE.txt), you must mention it here,
    so we can determine whether the license is compatible and what else needs
    to be done.

@barcharcraz barcharcraz requested a review from a team as a code owner February 25, 2020 02:25
configurationRegexFilter: '.*${{ parameters.targetPlatform }}.*'
buildDirectory: $(Build.ArtifactStagingDirectory)/${{ parameters.targetPlatform }}
variables:
vcpkgLocation: "$(Build.SourcesDirectory)/vcpkg"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's with all of these "single-quote to double-quote" changes? They greatly obscure the actual functional changes. Am I correct that the addition of clean: true on line 13 is the only functional change?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ugh it's the red-hat yaml extension for vscode.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

trying to be a little too clever.

@StephanTLavavej
Copy link
Member

I've linked #396, but please mention it in your commit message.

@barcharcraz barcharcraz merged commit 6d138d5 into microsoft:master Feb 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GitHub: File validation interacts badly with PRs adding submodules
3 participants