clean our repo before running CI #526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CaseyCarter
approved these changes
Feb 25, 2020
azure-devops/run_build.yml
Outdated
| configurationRegexFilter: '.*${{ parameters.targetPlatform }}.*' | ||
| buildDirectory: $(Build.ArtifactStagingDirectory)/${{ parameters.targetPlatform }} | ||
| variables: | ||
| vcpkgLocation: "$(Build.SourcesDirectory)/vcpkg" |
There was a problem hiding this comment.
What's with all of these "single-quote to double-quote" changes? They greatly obscure the actual functional changes. Am I correct that the addition of clean: true on line 13 is the only functional change?
There was a problem hiding this comment.
ugh it's the red-hat yaml extension for vscode.
There was a problem hiding this comment.
trying to be a little too clever.
undo format changes
barcharcraz
force-pushed
the
clean-repo
branch
from
0256d13
to
74c3de6
Compare
|
I've linked #396, but please mention it in your commit message. |
StephanTLavavej
approved these changes
Feb 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
tell azure pipelines to clean our repo before building, to prevent badness and broken CI pipelines.
This is a workaround for #396
Checklist
Be sure you've read README.md and understand the scope of this repo.
If you're unsure about a box, leave it unchecked. A maintainer will help you.
_Uglyas perhttps://eel.is/c++draft/lex.name#3.1 or there are no product code changes.
verified by an STL maintainer before automated testing is enabled on GitHub,
leave this unchecked for initial submission).
members, adding virtual functions, changing whether a type is an aggregate
or trivially copyable, etc.).
the C++ Working Draft (including any cited standards), other WG21 papers
(excluding reference implementations outside of proposed standard wording),
and LWG issues as reference material. If they were derived from a project
that's already listed in NOTICE.txt, that's fine, but please mention it.
If they were derived from any other project (including Boost and libc++,
which are not yet listed in NOTICE.txt), you must mention it here,
so we can determine whether the license is compatible and what else needs
to be done.