-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GitHub: File validation interacts badly with PRs adding submodules #396
Comments
@cbezault just encountered another form of this - submitting a PR that emits new files/directories that are also added to |
This wasn't cured after all - #2780 (adding a The raw_log.txt reveals the problem:
The However, other documentation suggests that we may be able to use In theory we can confirm that this works, although doing so would require a delicate dance. It might be easier to just inspect the logs to verify the true clean. |
Our automation to "validate" files for whitespace, line endings, and non-ASCII characters doesn't handle submodule additions very well. We have a hardcoded list of directories to skip when validating:
STL/tools/validate/validate.cpp
Lines 155 to 162 in 098333c
Here's the problem scenario:
cat
submodule, and updatesvalidate.cpp
to skip that directory.cat
PR hasn't been merged yet!mouse
machinery or whatever) triggers checks on those VMs.cat
directory, and themouse
PR doesn't containvalidate.cpp
changes to skipcat
, so all of thecat
files are scanned and fail to validate.I suspect that this is involved:
STL/azure-devops/run_build.yml
Lines 13 to 14 in 098333c
According to the YAML schema, do we need to set
clean: true
so we don't have to worry about lingering submodules?The text was updated successfully, but these errors were encountered: