Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

<mdspan>: Add new debug checks to layout mappings #3702

Merged
merged 2 commits into from
May 15, 2023
Merged

<mdspan>: Add new debug checks to layout mappings #3702

merged 2 commits into from
May 15, 2023

Conversation

JMazurkiewicz
Copy link
Contributor

@JMazurkiewicz JMazurkiewicz commented May 14, 2023 •
edited
Loading

@JMazurkiewicz JMazurkiewicz requested a review from a team as a code owner May 14, 2023 21:23
@StephanTLavavej StephanTLavavej added the mdspan C++23 mdspan label May 15, 2023
StephanTLavavej
StephanTLavavej approved these changes May 15, 2023
View reviewed changes
tests/std/tests/P0009R18_mdspan_layout_right/test.cpp Show resolved Hide resolved
tests/std/tests/P0009R18_mdspan_layout_stride_death/test.cpp
@@ -27,13 +27,20 @@ void test_construction_from_strided_layout_mapping() {
[[maybe_unused]] layout_stride::mapping<dextents<unsigned char, 1>> m2{m1};
}

void test_call_operator() {
layout_stride::mapping<extents<unsigned, 5, 3, 4>> m;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick for followup: We conventionally say unsigned int instead of unsigned.

@StephanTLavavej StephanTLavavej merged commit 67b9723 into microsoft:feature/mdspan2 May 15, 2023
@StephanTLavavej
Copy link
Member

Thanks, looks great! 😻 I had a couple of nitpicks for followup but they weren't worth resetting testing here, they can be addressed later.

@JMazurkiewicz JMazurkiewicz deleted the mdspan/index-in-space branch May 15, 2023 15:59
JMazurkiewicz added a commit to JMazurkiewicz/STL that referenced this pull request May 16, 2023
@JMazurkiewicz
Drive-by: address comments from previous PRs
8ab95b0 
* microsoft#3701 (comment)
* microsoft#3702 (comment)
* microsoft#3702 (comment)
@StephanTLavavej StephanTLavavej mentioned this pull request Aug 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

Assignees
No one assigned
Labels
mdspan C++23 mdspan
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JMazurkiewicz @StephanTLavavej