Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

<mdspan>: Remove some C28020 warning suppressions #3690

Merged
merged 3 commits into from
May 11, 2023
Merged

<mdspan>: Remove some C28020 warning suppressions #3690

merged 3 commits into from
May 11, 2023

Conversation

JMazurkiewicz
Copy link
Contributor

  • Remove all suppressions from <mdspan> header,
  • Remove suppressions from tests where possible,
  • Reduce the size of code with suppressed warning and add TRANSITION, DevCom-923103 comments.

@JMazurkiewicz JMazurkiewicz requested a review from a team as a code owner May 10, 2023 16:19
@StephanTLavavej StephanTLavavej added the mdspan C++23 mdspan label May 10, 2023
@StephanTLavavej StephanTLavavej self-assigned this May 10, 2023
@StephanTLavavej
Copy link
Member

Thanks! Out of paranoia, I have adjusted one suppression to encompass the entire statement as we haven't done subexpression suppression (outside of perhaps some _Pragmas) elsewhere. Will merge after the tests cycle.

@StephanTLavavej
Copy link
Member

I've pushed a merge to resolve a conflict - the warning suppression is still necessary despite the change from == to cmp_equal.

@StephanTLavavej StephanTLavavej merged commit 4bd089b into microsoft:feature/mdspan2 May 11, 2023
@StephanTLavavej
Copy link
Member

Thanks for all of these <mdspan> PRs, this is great progress! 🎉

@JMazurkiewicz JMazurkiewicz deleted the mdspan/warnings branch May 11, 2023 07:50
@JMazurkiewicz JMazurkiewicz mentioned this pull request May 14, 2023
Merged
@StephanTLavavej StephanTLavavej mentioned this pull request Aug 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

Assignees

@StephanTLavavej StephanTLavavej

Labels
mdspan C++23 mdspan
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JMazurkiewicz @StephanTLavavej