Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add simple config system #308

Closed
wants to merge 2 commits into from
Closed

add simple config system #308

wants to merge 2 commits into from

Conversation

peendebak
Copy link
Contributor

This is a small wrapper over the default python configparser

Changes proposed in this pull request:

  • Create config object in qcodes
  • Set some default values in the config object

@giulioungaretti @alexcjohnson

@qcodes-bot
Copy link

Current coverage is 82.74% (diff: 75.00%)

Merging #308 into master will decrease coverage by 0.07%

@@             master       #308   diff @@
==========================================
  Files            34         35     +1   
  Lines          3615       3651    +36   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits           2994       3021    +27   
- Misses          621        630     +9   
  Partials          0          0          

Powered by Codecov. Last update 934b83d...2391397

@qcodes-bot
Copy link

Codacy Here is an overview of what got changed by this pull request:

Issues
======
- Added 3

See the complete overview on Codacy

self.read(cfile)

def add_entry(self, combined_key: str, value):
""" Add an entry to the config system

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codacy Issue found: Trailing whitespace

for k in kk[:-1]:
try:
p[k]
except:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


def add_entry(self, combined_key: str, value):
""" Add an entry to the config system

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codacy Issue found: Trailing whitespace

@giulioungaretti giulioungaretti deleted the qconfig branch February 9, 2017 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants