-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add simple config system #308
Conversation
Current coverage is 82.74% (diff: 75.00%)@@ master #308 diff @@
==========================================
Files 34 35 +1
Lines 3615 3651 +36
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 2994 3021 +27
- Misses 621 630 +9
Partials 0 0
|
Here is an overview of what got changed by this pull request: Issues
======
- Added 3
See the complete overview on Codacy |
self.read(cfile) | ||
|
||
def add_entry(self, combined_key: str, value): | ||
""" Add an entry to the config system |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Issue found: Trailing whitespace
for k in kk[:-1]: | ||
try: | ||
p[k] | ||
except: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Issue found: No exception type(s) specified
|
||
def add_entry(self, combined_key: str, value): | ||
""" Add an entry to the config system | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Issue found: Trailing whitespace
This is a small wrapper over the default python
configparser
Changes proposed in this pull request:
@giulioungaretti @alexcjohnson