-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
show_subprocess_widget causes problems outside the notebook #316
Comments
@peendebak more information on the problems you get would be really helpful ! My best guess is that really your troubles are from the stream_queue that captures the stdout/stderr . |
@giulioungaretti With command line my scripts hang, with spyder is have random crashes. I don't think more information is needed: there is no reason why notebook functions should be executed when there is no notebook running. |
@giulioungaretti The crash is reproducible now. When I start an instrument on the server the module from IPython.display import display
from qcodes.widgets.widgets import HiddenUpdateWidget The loading of
The only proper fix for this is to make loading the ipython widgets optional. |
Which means breaking plotting as far as I know it's implement with a javacrpit/python widgets that a calls periodically an update function. |
@giulioungaretti Qt plotting works fine without these widgets (also see #290). Matplotlib plotting I have not checked. The loading of ipython widgets is optional and on by default so this will not break anything for normal notebook users. For users not using ipython notebook the current code does not work, so there should be some method to prevent loading these widgets. |
The
show_subprocess_widget
causes problems with systems not using ipython notebook (command line, spyder). A first approach to solving is was made in PR #278, but no definite conclusion was reached on how to solve it. There are a few options:frontend()
is introduced that determined whether the widgets are loaded or not. The function itself check an environment variable to determine whether we are in notebook mode or notshow_subprocess_widget
entirely@giulioungaretti @alexcjohnson
The text was updated successfully, but these errors were encountered: