Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Localization] Migrate resources to resx for FancyZones #6106

Merged
merged 39 commits into from
Aug 25, 2020

Conversation

arjunbalgovind
Copy link
Contributor

@arjunbalgovind arjunbalgovind commented Aug 21, 2020

Summary of the Pull Request

What is this about?
This PR migrates the resources for FancyZones to resx as per the steps done in #6057. The PR is currently made towards that branch to minimize the diff.

PR Checklist

Info on Pull Request

What does this include?

  • Moved fancy zones resources to resx.
  • Added build script and base rc and h files
  • Added LocProject.json

Validation Steps Performed

How does someone test & validate?

  • Validated that the project builds on CDPX
  • Validated that strings appear on OS version 1809 in old Settings

@arjunbalgovind arjunbalgovind added Product-FancyZones Refers to the FancyZones PowerToy Area-Localization issues regarding to Localization the application labels Aug 21, 2020
@arjunbalgovind arjunbalgovind requested review from enricogior and a team August 21, 2020 22:12
@enricogior
Copy link
Contributor

@SeraphimaZ can you please review it? Thanks.

@SeraphimaZykova
Copy link
Collaborator

SeraphimaZykova commented Aug 24, 2020

@SeraphimaZ can you please review it? Thanks.

I'm unable to validate that the project builds on CDPX since I haven't got access.
Built locally and validated that in old Settings strings appear.

Copy link
Contributor

@enricogior enricogior left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, works as expected. Nice work!

@arjunbalgovind arjunbalgovind changed the base branch from user/arbalgov/resxRCConversion to master August 24, 2020 23:10
@arjunbalgovind arjunbalgovind merged commit aebd765 into master Aug 25, 2020
@arjunbalgovind arjunbalgovind deleted the user/arbalgov/resxFZ branch August 25, 2020 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Localization issues regarding to Localization the application Product-FancyZones Refers to the FancyZones PowerToy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants