Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Localization] Migrate C++ project resources to resx files and set up scripts to convert to rc file at build time #6055

Closed
9 tasks done
arjunbalgovind opened this issue Aug 19, 2020 · 2 comments
Closed
9 tasks done

[Localization] Migrate C++ project resources to resx files and set up scripts to convert to rc file at build time #6055

arjunbalgovind opened this issue Aug 19, 2020 · 2 comments
Assignees
@arjunbalgovind
Labels
Area-Localization issues regarding to Localization the application Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
InVEST-2008

Comments

@arjunbalgovind
Copy link
Contributor

arjunbalgovind commented Aug 19, 2020 •
edited
Loading

Since CDPX localization does not support rc files, we have to convert the resources to resx files, and at build time these would get converted to rc files so that they are usable with C++ projects. This would also make it easier to migrate to WinUI 3 in the future.

The following projects need to be modified:

  • FancyZones
  • PowerRename
  • Shortcut Guide
  • Keyboard Manager
  • Image Resizer
  • Color Picker (module)
  • PowerToys Run (module)
  • Preview Pane Handler (module)
  • Shortcut Guide
@arjunbalgovind arjunbalgovind added the Area-Localization issues regarding to Localization the application label Aug 19, 2020
@arjunbalgovind arjunbalgovind self-assigned this Aug 19, 2020
This was referenced Aug 19, 2020
Closed
Merged
@arjunbalgovind arjunbalgovind added the Status-In progress This issue or work-item is under development label Aug 19, 2020
@enricogior
Copy link
Contributor

@arjunbalgovind
please make sure to coordinate when making this change for FancyZones, ShortcutGuide and PowerRename to minimize conflicts with other work in progress.

@crutkas crutkas added this to the InVEST-2008 milestone Aug 20, 2020
This was referenced Aug 21, 2020
Merged
Merged
Merged
@arjunbalgovind arjunbalgovind added Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed Status-In progress This issue or work-item is under development labels Aug 25, 2020
@crutkas
Copy link
Member

crutkas commented Sep 2, 2020

This should be resolved in our 0.21.1 release of PowerToys. https://github.com/microsoft/PowerToys/releases/tag/v0.21.1 to download it.

@crutkas crutkas closed this as completed Sep 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arjunbalgovind arjunbalgovind

Labels
Area-Localization issues regarding to Localization the application Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
InVEST-2008
Development

No branches or pull requests
3 participants
@crutkas @enricogior @arjunbalgovind