[Workspaces] Implement PWA recognition, launch. #35913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…controls to the editor
…ocesses. Update LauncherUI, Launcher
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
crutkas
added
the
Needs-Review
This comment has been minimized.
This comment has been minimized.
…y (code cleaning) and updating json parser in Launcher
SeraphimaZykova
requested changes
Nov 18, 2024
src/modules/Workspaces/WorkspacesCsharpLibrary/WorkspacesCsharpLibrary.csproj
Outdated
Show resolved
Hide resolved
src/modules/Workspaces/WorkspacesEditor/ViewModels/MainViewModel.cs
Outdated
Show resolved
Hide resolved
src/modules/Workspaces/WorkspacesEditor/ViewModels/MainViewModel.cs
Outdated
Show resolved
Hide resolved
SeraphimaZykova
requested changes
Nov 19, 2024
src/modules/Workspaces/WorkspacesSnapshotTool/SnapshotUtils.cpp
Outdated
Show resolved
Hide resolved
src/modules/Workspaces/WorkspacesSnapshotTool/SnapshotUtils.cpp
Outdated
Show resolved
Hide resolved
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
With this code addition the Workspaces will be able to handle PWA applications installed in Edge or Chrome.
The snapshot tool will detect the running PWA apps, get their PwaAppId, which will be stored in the workspaces.json file.
The Editor (and later the Launcher UI) will show the corresponding app name and the app icon.
The launcher will launch the Pwa apps.
PR Checklist
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed
Tested locally on a scenarios where there were 3 different edge-Pwa-apps, 3 different chrome-Pwa-apps, edge and chrome also and other apss too.