Fix missing response schema bug

src/Microsoft.OpenApi.Readers/V2/OpenApiOperationDeserializer.cs

@@ -67,7 +67,7 @@ internal static partial class OpenApiV2Deserializer
                 {
                     "produces", (o, n) => {
                         var produces = n.CreateSimpleList(s => s.GetScalarValue());
-                        if (produces != null) {
+                        if (produces.Count > 0) {
                             n.Context.SetTempStorage(TempStorageKeys.OperationProduces, produces);
                         }
                     }

src/Microsoft.OpenApi.Readers/V2/OpenApiResponseDeserializer.cs

@@ -73,47 +73,34 @@ private static void ProcessProduces(MapNode mapNode, OpenApiResponse response, P
             }
 
             var produces = context.GetFromTempStorage<List<string>>(TempStorageKeys.OperationProduces)
-                ?? context.GetFromTempStorage<List<string>>(TempStorageKeys.GlobalProduces);
+                ?? new List<string> { "application/octet-stream" };
 
-            if (produces != null)
+            var schema = context.GetFromTempStorage<OpenApiSchema>(TempStorageKeys.ResponseSchema, response);
+
+            foreach (var produce in produces)
             {
-                var schema = context.GetFromTempStorage<OpenApiSchema>(TempStorageKeys.ResponseSchema, response);
 
-                if (produces.Count == 0 && schema != null)
+                if (response.Content.ContainsKey(produce) && response.Content[produce] != null)
                 {
-                    var mediaType = new OpenApiMediaType
+                    if (schema != null)
                     {
-                        Schema = schema
-                    };
-
-                    response.Content.Add(string.Empty, mediaType);
+                        response.Content[produce].Schema = schema;
+                        ProcessAnyFields(mapNode, response.Content[produce], _mediaTypeAnyFields);
+                    }
                 }
-
-                foreach (var produce in produces)
+                else
                 {
-
-                    if (response.Content.ContainsKey(produce) && response.Content[produce] != null)
-                    {
-                        if (schema != null)
-                        {
-                            response.Content[produce].Schema = schema;
-                            ProcessAnyFields(mapNode, response.Content[produce], _mediaTypeAnyFields);
-                        }
-                    }
-                    else
+                    var mediaType = new OpenApiMediaType
                     {
-                        var mediaType = new OpenApiMediaType
-                        {
-                            Schema = schema
-                        };
+                        Schema = schema
+                    };
 
-                        response.Content.Add(produce, mediaType);
-                    }
+                    response.Content.Add(produce, mediaType);
                 }
-
-                context.SetTempStorage(TempStorageKeys.ResponseSchema, null, response);
-                context.SetTempStorage(TempStorageKeys.ResponseProducesSet, true, response);
             }
+
+            context.SetTempStorage(TempStorageKeys.ResponseSchema, null, response);
+            context.SetTempStorage(TempStorageKeys.ResponseProducesSet, true, response);
         }
 
         private static void LoadExamples(OpenApiResponse response, ParseNode node)

test/Microsoft.OpenApi.Readers.Tests/Microsoft.OpenApi.Readers.Tests.csproj

@@ -51,6 +51,9 @@
         <EmbeddedResource Include="V2Tests\Samples\OpenApiOperation\operationWithBody.yaml">
             <CopyToOutputDirectory>Never</CopyToOutputDirectory>
         </EmbeddedResource>
+        <EmbeddedResource Include="V2Tests\Samples\OpenApiOperation\operationWithBodyAndEmptyConsumes.yaml">
+            <CopyToOutputDirectory>Never</CopyToOutputDirectory>
+        </EmbeddedResource>
         <EmbeddedResource Include="V2Tests\Samples\OpenApiOperation\operationWithFormData.yaml">
             <CopyToOutputDirectory>Never</CopyToOutputDirectory>
         </EmbeddedResource>

test/Microsoft.OpenApi.Readers.Tests/V2Tests/OpenApiOperationTests.cs

@@ -182,8 +182,8 @@ public class OpenApiOperationTests
                         }
                     }
                 },
-                Extensions = { 
-                    [OpenApiConstants.BodyName] = new OpenApiString("petObject") 
+                Extensions = {
+                    [OpenApiConstants.BodyName] = new OpenApiString("petObject")
                 }
             },
             Responses = new OpenApiResponses
@@ -381,10 +381,8 @@ public void ParseOperationWithEmptyProducesArraySetsResponseSchemaIfExists()
         {
             // Arrange
             MapNode node;
-            using (var stream = Resources.GetStream(Path.Combine(SampleFolderPath, "operationWithEmptyProducesArrayInResponse.json")))
-            {
-                node = TestHelper.CreateYamlMapNode(stream);
-            }
+            using var stream = Resources.GetStream(Path.Combine(SampleFolderPath, "operationWithEmptyProducesArrayInResponse.json"));
+            node = TestHelper.CreateYamlMapNode(stream);
 
             // Act
             var operation = OpenApiV2Deserializer.LoadOperation(node);
@@ -400,7 +398,7 @@ public void ParseOperationWithEmptyProducesArraySetsResponseSchemaIfExists()
                             Description = "OK",
                             Content =
                             {
-                                [""] = new OpenApiMediaType()
+                                ["application/octet-stream"] = new OpenApiMediaType()
                                 {
                                     Schema = new OpenApiSchema()
                                     {
@@ -419,5 +417,20 @@ public void ParseOperationWithEmptyProducesArraySetsResponseSchemaIfExists()
                 }
             );
         }
+
+        [Fact]
+        public void ParseOperationWithBodyAndEmptyConsumesSetsRequestBodySchemaIfExists()
+        {
+            // Arrange
+            MapNode node;
+            using var stream = Resources.GetStream(Path.Combine(SampleFolderPath, "operationWithBodyAndEmptyConsumes.yaml"));
+            node = TestHelper.CreateYamlMapNode(stream);
+
+            // Act
+            var operation = OpenApiV2Deserializer.LoadOperation(node);
+
+            // Assert
+            operation.Should().BeEquivalentTo(_operationWithBody);
+        }
     }
 }

test/Microsoft.OpenApi.Readers.Tests/V2Tests/Samples/OpenApiOperation/operationWithBodyAndEmptyConsumes.yaml

@@ -0,0 +1,25 @@
+# Modified from https://github.com/OAI/OpenAPI-Specification/blob/master/versions/2.0.md#operation-object-example
+summary: Updates a pet in the store with request body
+description: ""
+operationId: updatePetWithBody
+consumes: []
+produces:
+- application/json
+- application/xml
+parameters:
+- name: petId
+  in: path
+  description: ID of pet that needs to be updated
+  required: true
+  type: string
+- name: petObject
+  in: body
+  description: Pet to update with
+  required: true
+  schema: 
+    type: object
+responses:
+  '200':
+    description: Pet updated.
+  '405':
+    description: Invalid input