Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing response schema bug #1316

Merged
merged 19 commits into from
Aug 31, 2023
Merged

Fix missing response schema bug #1316

merged 19 commits into from
Aug 31, 2023

Conversation

MaggieKimani1
Copy link
Contributor

Fixes #1315

baywet
baywet previously approved these changes Aug 21, 2023
View reviewed changes
@darrelmiller
Copy link
Member

Do we need to make the same fix for empty Consumes array?

@MaggieKimani1
Copy link
Contributor Author

MaggieKimani1 commented Aug 22, 2023 •
edited
Loading

Do we need to make the same fix for empty Consumes array?

Turns out our code already assumes application/json for a body or application/x-url-encoded-form for form data even with an empty consumes array. I've added a unit test to assert that it works.

darrelmiller
darrelmiller previously approved these changes Aug 31, 2023
View reviewed changes
@MaggieKimani1 MaggieKimani1 disabled auto-merge August 31, 2023 20:20
@MaggieKimani1 MaggieKimani1 merged commit c377232 into vnext Aug 31, 2023
@MaggieKimani1 MaggieKimani1 deleted the mk/fix-missing-response-schema-bug branch August 31, 2023 20:21
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

8.8% 8.8% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baywet baywet baywet approved these changes

@darrelmiller darrelmiller darrelmiller left review comments

@irvinesunday irvinesunday Awaiting requested review from irvinesunday

@peombwa peombwa Awaiting requested review from peombwa

@zengin zengin Awaiting requested review from zengin

@millicentachieng millicentachieng Awaiting requested review from millicentachieng

@andrueastman andrueastman Awaiting requested review from andrueastman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incomplete OpenApiResponse
3 participants
@MaggieKimani1 @darrelmiller @baywet