Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[XPU] [DeepNVMe] use same cpu_op_desc_t with cuda #6645

Merged
merged 2 commits into from
Oct 22, 2024

Conversation

Liangliang-Ma
Copy link
Contributor

We have found that #6592 uses _pinned_tensor_mgr to create cpu bounce buffer, which is same with what our xpu accelerator currently doing.
So no need to use xpu device specific cpu_op_desc_t.
In this PR:

  1. remove custom csrc/xpu/aio/deepspeed_cpu_op.cpp
  2. modify xpu async_io opbuilder.

This issue cannot be easily done with revert #6532 , for we added some source file as last time GDS feature going in DS. So file this new PR :)

@Liangliang-Ma
Copy link
Contributor Author

@tjruwase Could you please help to re-trigger the checks for xpu-max1100 workflow updation#6646 ?
Thanks!

@tjruwase tjruwase added this pull request to the merge queue Oct 22, 2024
@tjruwase
Copy link
Contributor

@tjruwase Could you please help to re-trigger the checks for xpu-max1100 workflow updation#6646 ? Thanks!

@delock, are you able to trigger workflows?

Merged via the queue into microsoft:master with commit a24cdd6 Oct 22, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants