64bit indexing fused adam #5187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garrett4wade
requested review from
awan-10,
mrwyattii and
arashb
as code owners
@microsoft-github-policy-service agree |
mrwyattii
approved these changes
Mar 2, 2024
loadams
reviewed
Mar 13, 2024
| @@ -30,7 +30,7 @@ typedef enum : int { | |||
|
|
|||
| using MATH_T = float; | |||
|
|
|||
| template <typename T> | |||
| template <typename T, typename index_t> | |||
| struct AdamFunctor { | |||
| __device__ __forceinline__ void operator()(int chunk_size, | |||
There was a problem hiding this comment.
FYI this chunk_size is still an int and not int64/index_t
There was a problem hiding this comment.
@garrett4wade - thoughts on this?
loadams
approved these changes
Mar 13, 2024
|
FYI @garrett4wade - thoughts on the comments above or merging this PR? |
rraminen
pushed a commit
to ROCm/DeepSpeed
that referenced
this pull request
May 9, 2024
## The Issue Applying `FusedAdam` on large tensors will cause an error `CUDA error: an illegal memory access was encountered`. microsoft#3429 NVIDIA/apex#1654 ## PR Content Following the solution in the apex repository (NVIDIA/apex#1765), changing indexing type to `int64` if necessary. --------- Co-authored-by: Michael Wyatt <michaelwyatt@microsoft.com> Co-authored-by: Logan Adams <114770087+loadams@users.noreply.github.com>
umchand
pushed a commit
to umchand/DeepSpeed
that referenced
this pull request
May 20, 2024
## The Issue Applying `FusedAdam` on large tensors will cause an error `CUDA error: an illegal memory access was encountered`. microsoft#3429 NVIDIA/apex#1654 ## PR Content Following the solution in the apex repository (NVIDIA/apex#1765), changing indexing type to `int64` if necessary. --------- Co-authored-by: Michael Wyatt <michaelwyatt@microsoft.com> Co-authored-by: Logan Adams <114770087+loadams@users.noreply.github.com>
dbyoung18
pushed a commit
to dbyoung18/DeepSpeed
that referenced
this pull request
Jun 11, 2024
## The Issue Applying `FusedAdam` on large tensors will cause an error `CUDA error: an illegal memory access was encountered`. microsoft#3429 NVIDIA/apex#1654 ## PR Content Following the solution in the apex repository (NVIDIA/apex#1765), changing indexing type to `int64` if necessary. --------- Co-authored-by: Michael Wyatt <michaelwyatt@microsoft.com> Co-authored-by: Logan Adams <114770087+loadams@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Issue
Applying
FusedAdamon large tensors will cause an errorCUDA error: an illegal memory access was encountered.#3429
NVIDIA/apex#1654
PR Content
Following the solution in the apex repository (NVIDIA/apex#1765), changing indexing type to
int64if necessary.