64-bit indexing Adam #1765
Merged
64-bit indexing Adam #1765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crcrpar
approved these changes
Jan 4, 2024
| @@ -85,9 +85,9 @@ void multi_tensor_apply( | |||
| tl.addresses[d][loc_tensor_info] = tensor_lists[d][t].data_ptr(); | |||
| loc_tensor_info++; | |||
|
|
|||
| int chunks_this_tensor = (tensor_lists[0][t].numel() + chunk_size - 1)/chunk_size; | |||
| auto chunks_this_tensor = (tensor_lists[0][t].numel() + chunk_size - 1)/chunk_size; | |||
There was a problem hiding this comment.
would chunks_this_tensor tend to be int64_t given chunk_size being so?
github-merge-queue bot
pushed a commit
to microsoft/DeepSpeed
that referenced
this pull request
Apr 22, 2024
## The Issue Applying `FusedAdam` on large tensors will cause an error `CUDA error: an illegal memory access was encountered`. #3429 NVIDIA/apex#1654 ## PR Content Following the solution in the apex repository (NVIDIA/apex#1765), changing indexing type to `int64` if necessary. --------- Co-authored-by: Michael Wyatt <michaelwyatt@microsoft.com> Co-authored-by: Logan Adams <114770087+loadams@users.noreply.github.com>
github-merge-queue bot
pushed a commit
to microsoft/DeepSpeed
that referenced
this pull request
Apr 22, 2024
## The Issue Applying `FusedAdam` on large tensors will cause an error `CUDA error: an illegal memory access was encountered`. #3429 NVIDIA/apex#1654 ## PR Content Following the solution in the apex repository (NVIDIA/apex#1765), changing indexing type to `int64` if necessary. --------- Co-authored-by: Michael Wyatt <michaelwyatt@microsoft.com> Co-authored-by: Logan Adams <114770087+loadams@users.noreply.github.com>
rraminen
pushed a commit
to ROCm/DeepSpeed
that referenced
this pull request
May 9, 2024
## The Issue Applying `FusedAdam` on large tensors will cause an error `CUDA error: an illegal memory access was encountered`. microsoft#3429 NVIDIA/apex#1654 ## PR Content Following the solution in the apex repository (NVIDIA/apex#1765), changing indexing type to `int64` if necessary. --------- Co-authored-by: Michael Wyatt <michaelwyatt@microsoft.com> Co-authored-by: Logan Adams <114770087+loadams@users.noreply.github.com>
umchand
pushed a commit
to umchand/DeepSpeed
that referenced
this pull request
May 20, 2024
## The Issue Applying `FusedAdam` on large tensors will cause an error `CUDA error: an illegal memory access was encountered`. microsoft#3429 NVIDIA/apex#1654 ## PR Content Following the solution in the apex repository (NVIDIA/apex#1765), changing indexing type to `int64` if necessary. --------- Co-authored-by: Michael Wyatt <michaelwyatt@microsoft.com> Co-authored-by: Logan Adams <114770087+loadams@users.noreply.github.com>
dbyoung18
pushed a commit
to dbyoung18/DeepSpeed
that referenced
this pull request
Jun 11, 2024
## The Issue Applying `FusedAdam` on large tensors will cause an error `CUDA error: an illegal memory access was encountered`. microsoft#3429 NVIDIA/apex#1654 ## PR Content Following the solution in the apex repository (NVIDIA/apex#1765), changing indexing type to `int64` if necessary. --------- Co-authored-by: Michael Wyatt <michaelwyatt@microsoft.com> Co-authored-by: Logan Adams <114770087+loadams@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1654
I think the tests pass without the changes to
multi_tensor_apply.cuh, but leaving it as-is makes me a bit nervous...TODOs: graph-capturable Adam, and all other optimizers if people really need 64-bit indexing there...
CC @crcrpar