Ujjwalchadha/perf/eventsourcecodegen #852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manodasanW
reviewed
May 27, 2021
manodasanW
reviewed
May 27, 2021
manodasanW
reviewed
May 27, 2021
manodasanW
reviewed
May 27, 2021
manodasanW
reviewed
May 27, 2021
manodasanW
reviewed
May 27, 2021
manodasanW
reviewed
May 27, 2021
manodasanW
reviewed
May 27, 2021
Scottj1s
reviewed
Jun 3, 2021
Scottj1s
reviewed
Jun 3, 2021
Scottj1s
reviewed
Jun 3, 2021
Scottj1s
reviewed
Jun 3, 2021
Scottj1s
reviewed
Jun 3, 2021
Scottj1s
reviewed
Jun 3, 2021
Scottj1s
reviewed
Jun 3, 2021
Scottj1s
reviewed
Jun 3, 2021
Scottj1s
reviewed
Jun 3, 2021
| @@ -188,6 +192,7 @@ Where <spec> is one or more of: | |||
| continue; | |||
| } | |||
| auto guard{ w.push_generic_params(type.GenericParam()) }; | |||
| auto guard1{ helperWriter.push_generic_params(type.GenericParam()) }; | |||
There was a problem hiding this comment.
I don't think helperWriter is needed - you're only ever calling write_temp
There was a problem hiding this comment.
I believe we do need this because it is tied to the generic params that we set here. The write_temp functions uses the generic_params that we push to the helperWriter to write the type name and so on
There was a problem hiding this comment.
but w is pushing those very same generic params. can you try?
Scottj1s
reviewed
Jun 8, 2021
manodasanW
reviewed
Jun 9, 2021
manodasanW
reviewed
Jun 9, 2021
manodasanW
approved these changes
Jun 9, 2021
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the performance of subscribing to new events by removing the need for reflection. We precompute the handlers that the native code needs to invoke using the cswinrt code generator rather than compiling them at runtime using reflection. A new benchmark has been added to compute and compare the performance of an event being subscribed and invoked.