Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance improvements to event sources #648

Closed
3 tasks done
ujjwalchadha opened this issue Jan 4, 2021 · 0 comments · Fixed by #852
Closed
3 tasks done

Performance improvements to event sources #648

ujjwalchadha opened this issue Jan 4, 2021 · 0 comments · Fixed by #852
Assignees
@manodasanW @ujjwalchadha
Labels
fixed Issue has been fixed in an upcoming or existing release performance Related to performance work
Milestone
Release 1.3.0

Comments

@ujjwalchadha
Copy link
Contributor

ujjwalchadha commented Jan 4, 2021 •
edited
Loading

  • _eventInvoke is per-instance and could be made static for each TDelegate type
  • Check whether some of our Expression.Lambda stuff could be rearranged into a generic and instantiated where needed to produce a delegate
  • Investigate generating event sources using a source generator for TDelegate types already known
@ujjwalchadha ujjwalchadha added the performance Related to performance work label Jan 4, 2021
@AdamBraden AdamBraden modified the milestones: Release 1.2.0, Release 1.3 Jan 6, 2021
@chrisglein chrisglein mentioned this issue Jan 29, 2021
Closed
@manodasanW manodasanW changed the title Add caching for event source Performance improvements to event sources May 4, 2021
@ujjwalchadha ujjwalchadha linked a pull request Jun 15, 2021 that will close this issue
Ujjwalchadha/perf/eventsourcecodegen #852
Merged
@angelazhangmsft angelazhangmsft added the fixed Issue has been fixed in an upcoming or existing release label Jun 17, 2021
@manodasanW manodasanW mentioned this issue Jun 21, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@manodasanW manodasanW

@ujjwalchadha ujjwalchadha

Labels
fixed Issue has been fixed in an upcoming or existing release performance Related to performance work
Projects
None yet
Milestone
Release 1.3.0
Development

Successfully merging a pull request may close this issue.

Ujjwalchadha/perf/eventsourcecodegen microsoft/CsWinRT
4 participants
@manodasanW @AdamBraden @ujjwalchadha @angelazhangmsft