Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2794 & 2510 Fix change local, hybrid react, and clear after idle samples #2798

Merged
merged 4 commits into from
Jan 6, 2020
Merged

2794 & 2510 Fix change local, hybrid react, and clear after idle samples #2798

merged 4 commits into from
Jan 6, 2020

Conversation

corinagum
Copy link
Contributor

@corinagum corinagum commented Jan 5, 2020 •
edited
Loading

Fixes #2794, fixes #2510

Changelog Entry

Description

All three samples weren't working, this makes sure the demos are now available on GH pages without errors.

- [ ] Testing Added

@coveralls
Copy link

Coverage Status

Coverage remained the same at 65.89% when pulling 6ee23f5 on corinagum:2794 into 0374125 on microsoft:master.

tdurnford
tdurnford approved these changes Jan 6, 2020
View reviewed changes
Copy link
Contributor

@tdurnford tdurnford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@corinagum corinagum merged commit 04fe2c3 into microsoft:master Jan 6, 2020
@compulim compulim mentioned this pull request Mar 5, 2020
Closed
40 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tdurnford tdurnford tdurnford approved these changes

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n a-b-r-o-w-n is a code owner

@compulim compulim Awaiting requested review from compulim compulim is a code owner

@cwhitten cwhitten Awaiting requested review from cwhitten cwhitten is a code owner

@srinaath srinaath Awaiting requested review from srinaath srinaath is a code owner

@tonyanziano tonyanziano Awaiting requested review from tonyanziano

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Investigate change locale sample Host sample 23.a.hybrid-react-npm
3 participants
@corinagum @coveralls @tdurnford