Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate change locale sample #2794

Closed
corinagum opened this issue Jan 3, 2020 · 0 comments · Fixed by #2798
Closed

Investigate change locale sample #2794

corinagum opened this issue Jan 3, 2020 · 0 comments · Fixed by #2798
Assignees
@corinagum
Labels
bug Indicates an unexpected problem or an unintended behavior. p2 Nice to have

Comments

@corinagum
Copy link
Contributor

Looks like the demo does not match the README. Needs to be fixed.

Original comment: #2762 (comment)
@corinagum corinagum added bug Indicates an unexpected problem or an unintended behavior. QOL labels Jan 3, 2020
@corinagum corinagum self-assigned this Jan 3, 2020
@corinagum corinagum added the p2 Nice to have label Jan 3, 2020
@corinagum corinagum mentioned this issue Jan 3, 2020
Merged
1 task
corinagum added a commit to corinagum/BotFramework-WebChat that referenced this issue Jan 5, 2020
@corinagum
microsoft#2794: Fix change-locale sample
1f25798
@corinagum corinagum mentioned this issue Jan 5, 2020
Merged
corinagum added a commit that referenced this issue Jan 6, 2020
@corinagum
2794 & 2510 Fix change local, hybrid react, and clear after idle samp…
04fe2c3 
…les (#2798)

* #2794: Fix change-locale sample

* #2510 host hybrid-react and clear-after-idle samples

* Update CHANGELOG.md
@compulim compulim mentioned this issue Mar 5, 2020
Closed
40 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@corinagum corinagum

Labels
bug Indicates an unexpected problem or an unintended behavior. p2 Nice to have
Projects
None yet
Milestone
No milestone
1 participant
@corinagum