Move isomorphic-react-* to devDependencies #2486
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Entry
Fixed
isomorphic-react
andisomorphic-react-dom
packages, by @compulim and @corinagum, in PR #2478 and PR #2486Description
isomorphic-react-*
is for loading React fromwindow.React
and fallback toimport React from 'react'
. And this is for bundle only, i.e. Webpack.We shouldn't need to put
isomorphic-react-*
in production dependencies because they are not published.Specific Changes
In bundle package, move
isomorhic-react-*
fromdependencies
todevDependencies
.