Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Web Chat errors when built inside a React app of a different version that uses hooks #2461

Closed
corinagum opened this issue Oct 10, 2019 · 1 comment · Fixed by #2478 or #2486
Closed

Web Chat errors when built inside a React app of a different version that uses hooks #2461

corinagum opened this issue Oct 10, 2019 · 1 comment · Fixed by #2478 or #2486
Assignees
@corinagum
Labels
bug Indicates an unexpected problem or an unintended behavior.

Comments

@corinagum
Copy link
Contributor

image

Version

latest bits

Describe the bug

Using hooks in a React App that hosts Web Chat, but uses a different version of React, results in error.

To Reproduce

Steps to reproduce the behavior:

  1. Build a basic React App using React version 16.8.0
  2. Insert the following hook: React.useEffect(() => console.log('mounted'), []);
  3. Host Web Chat inside the app
  4. Run and open the page in a browser.
  5. Note that the page does not build, and there are console errors like screenshot above

Expected behavior

App should not error out.

Additional context

@compulim has is fix in the bit Redux Hooks PR, but needs to extract it in time for 4.6

[Bug]
@corinagum corinagum added bug Indicates an unexpected problem or an unintended behavior. Pending labels Oct 10, 2019
@corinagum corinagum added the needs-repro Waiting for repro or investigation label Oct 10, 2019
@corinagum corinagum removed the Pending label Oct 11, 2019
@corinagum corinagum removed the needs-repro Waiting for repro or investigation label Oct 11, 2019
@corinagum corinagum assigned corinagum and unassigned compulim Oct 15, 2019
@corinagum
Copy link
Contributor Author

Load balancing @compulim; I'll give this a shot.

This was referenced Oct 15, 2019
Closed
Merged
@corinagum corinagum added the 4.6 label Oct 16, 2019
compulim pushed a commit that referenced this issue Oct 18, 2019
@corinagum @compulim
#2461 Add isomorphic-react and isomorphic-react-dom packages (#2478)
3f70e3b 
* Add package 'isomorphic react'

* Add package 'isomorphic react-DOM'

* Update all packages

* Cleanup readmes

* Bump sample packages/more prettify readmes

* Update CHANGELOG.md

* Implement PR fixes

* Fix eslint errors??

* Lock down on react & adaptive cards packages

* Add review suggestions

* Fix failing tests

* Fix failing test

* Wait for audio to be buffered completely

* Update URLs

* Moving to non-pure component

* Add sleep
@compulim compulim mentioned this issue Oct 22, 2019
Merged
1 task
@compulim compulim mentioned this issue Oct 25, 2019
Closed
55 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@corinagum corinagum

Labels
bug Indicates an unexpected problem or an unintended behavior.
Projects
None yet
Milestone
No milestone
2 participants
@compulim @corinagum