Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix receipt card and disabled Adaptive Cards #2417

Merged
merged 4 commits into from
Sep 25, 2019
Merged

Fix receipt card and disabled Adaptive Cards #2417

merged 4 commits into from
Sep 25, 2019

Conversation

compulim
Copy link
Contributor

@compulim compulim commented Sep 22, 2019 •
edited
Loading

Fixes #2415.
Fixes #2416.

Changelog Entry

Fixed

Description

Two issues:

  • Receipt card rendering is broken since React functional component push
  • Adaptive Cards cannot be disabled on-the-fly
    • When disabled, no input fields cannot be changed by user
    • When disabled, links and buttons should be disabled
    • Can be re-enabled and all links and buttons should continue to work

Specific Changes

  • Fixes for issues mentioned above
  • Added tests for:
    • Receipt card rendering
    • Adaptive Card disabled, make sure fields are saved
    • Scroll to bottom
  • Testing Added

@coveralls
Copy link

coveralls commented Sep 22, 2019 •
edited
Loading

Coverage Status

Coverage increased (+2.2%) to 67.586% when pulling 65d404a on compulim:fix-2415 into 2de5ecd on microsoft:master.

tdurnford
tdurnford approved these changes Sep 23, 2019
View reviewed changes
Copy link
Contributor

@tdurnford tdurnford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@compulim compulim force-pushed the fix-2415 branch 2 times, most recently from 7ea76ac to fd3bfff Compare September 24, 2019 23:35
@compulim compulim merged commit 850890f into microsoft:master Sep 25, 2019
@compulim compulim deleted the fix-2415 branch September 25, 2019 06:32
@compulim compulim mentioned this pull request Oct 4, 2019
Closed
13 tasks
@compulim compulim mentioned this pull request Oct 25, 2019
Closed
55 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tdurnford tdurnford tdurnford approved these changes

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n a-b-r-o-w-n is a code owner

@corinagum corinagum Awaiting requested review from corinagum

@cwhitten cwhitten Awaiting requested review from cwhitten cwhitten is a code owner

@tonyanziano tonyanziano Awaiting requested review from tonyanziano

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adaptive Cards cannot be disabled on-the-fly Receipt card is not rendering correctly
3 participants
@compulim @coveralls @tdurnford