Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump react-film #1826

Closed
wants to merge 22 commits into from
Closed

Bump react-film #1826

wants to merge 22 commits into from

Conversation

corinagum
Copy link
Contributor

@corinagum corinagum commented Mar 20, 2019 •
edited
Loading

Fixes #1759
Fixes #1707

image

@coveralls
Copy link

coveralls commented Mar 20, 2019 •
edited
Loading

Coverage Status

Coverage increased (+2.2%) to 54.132% when pulling 755ab96 on corinagum:corinagum/react-film into 1512fe6 on Microsoft:master.

@corinagum
Copy link
Contributor Author

Waiting on this for some react-film updates. Right now there's a breaking change.

@corinagum corinagum added the PR: On hold For PR's placed on the backburner label Mar 21, 2019
Corina added 2 commits March 21, 2019 11:44
Add word-wrap to messageActivity (microsoft#1832)
1fc6ab4 
* Add word-wrap to messageActivity

* Update CHANGELOG.md

* Add test for break-all

* Add keep-all test
Bump react-say (microsoft#1849)
4968998 
* Bump react-say

* Update CHANGELOG.md
@corinagum corinagum added the 4.4 label Apr 2, 2019
Corina and others added 9 commits April 3, 2019 16:38
Add Stack Overflow redirect questions to answer templates (microsoft#…
16e33e1 
…1868)

* Add How To Questions template

* Add extra info
Update README.md
48f283c
1523 Offline UI - connecting for the first time (microsoft#1866)
7240ad9 
* Add new localization strings for Offline UI

* Add spinner animation

* linting fixes

* Update ConnectivityStatus

* Fix tests with ConnectivityStatus feature & add test

* 1856 fix sample 09

* Test revisions

* Minor number fix

* Update CHANGELOG.md

* PR cleanup
Add ability to style all send box borders (microsoft#1871)
c7a39e6 
* Add ability to style all send box borders

* Update CHANGELOG.md

* Fix order of style options
Remove renderer for unknown activities (microsoft#1873)
f68cf3c 
* Remove renderer for unknown activity

* Update CHANGELOG.md
@cwhitten
Add ability to style suggested action flippers (microsoft#1883)
e561bc4 
* Add ability to style suggested action flippers

* Update CHANGELOG.md
Fix CSS collisions with Bootstrap and bump memoize-one (microsoft#1884)
c2f9021 
* Add webchat prefix to row class

* Bump memoize-one

* Update CHANGELOG.md

* Update webchat__row to BEM naming convention
Update README.md
5426c6c
Update README.md
eaa3f61
@cwhitten cwhitten added p1 Painful if we don't fix, won't block releasing and removed PR: On hold For PR's placed on the backburner labels Apr 10, 2019
compulim and others added 2 commits April 10, 2019 16:41
@compulim @cwhitten
Add reconnection logic (microsoft#1880)
4b8488e 
* Add reconnection

* Add entry

* Update packages/core/src/sagas.js

Co-Authored-By: compulim <compulim@users.noreply.github.com>

* Update packages/core/src/sagas/connectSaga.js

Co-Authored-By: compulim <compulim@users.noreply.github.com>

* Handling disconnect during connection

* Add comments

* Fix parenthesis

* Fix yield

* Add test

* DISCONNECT_FULFILLED could also means disconnect due to errors
Add Migration Guide & the beginning of an API (microsoft#1888)
fc5ad8d 
* Add to migration story from v3 to v4

* Add table of renderWebChat properties

* Clean up readme and Composer.js

* Further README.MD clean up

* PR fixes
tdurnford and others added 2 commits April 11, 2019 21:19
@tdurnford @cwhitten
Wrapping input text (microsoft#1889)
79c39e5 
* Wrapping input text

* Wrapping input text

* Added more unit tests and modified styles slightly.

* Changed sendBoxScrollingTextInput to sendBoxTextWrap

* Reverted changes to test

* adjusted text input padding and correct issue with textarea tests

* fixed textarea send on enter test.

* updated change log
@compulim
Bump react-film@1.2.1-master.86ba8c1
f289f0c
@compulim
Copy link
Contributor

@corinagum I just bumped to another version of react-film.

Could you check if everything works great with this version?

@corinagum corinagum assigned corinagum and unassigned compulim Apr 15, 2019
@corinagum
Copy link
Contributor Author

closing because I did the merge wrong >.>

@corinagum corinagum closed this Apr 15, 2019
@corinagum corinagum mentioned this pull request Apr 15, 2019
Merged
@corinagum corinagum deleted the corinagum/react-film branch April 15, 2019 18:24
@corinagum corinagum restored the corinagum/react-film branch April 15, 2019 18:24
@corinagum corinagum deleted the corinagum/react-film branch April 15, 2019 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compulim compulim compulim approved these changes

@a-b-r-o-w-n a-b-r-o-w-n a-b-r-o-w-n approved these changes

@cwhitten cwhitten Awaiting requested review from cwhitten cwhitten is a code owner

@justinwilaby justinwilaby Awaiting requested review from justinwilaby

@tonyanziano tonyanziano Awaiting requested review from tonyanziano

Assignees

@corinagum corinagum

Labels
p1 Painful if we don't fix, won't block releasing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ChoicePrompt Slider Button causes page refresh Carousel does not work when it contains a <ul>
6 participants
@corinagum @coveralls @compulim @a-b-r-o-w-n @cwhitten @tdurnford