Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove renderer for unknown activities #1873

Merged
merged 2 commits into from
Apr 4, 2019
Merged

Conversation

corinagum
Copy link
Contributor

Fix #1827

This fix removes the render for unknown activities to Web Chat (all activities excluding Message, Event, and Typing). For users wanting to create their own rendering component based off of an activity, take a look at incoming activities and creating custom components sample.
image

The above screencap is what is rendered when the following activity is sent by the bot:

{
     type: 'x-unknown-activity',
     attachments: [{
       contentType: 'x-unknown-attachment',
       content: {}
     }]
}

@cwhitten
Copy link
Member

cwhitten commented Apr 4, 2019

it looks like the build failed on travis.

@corinagum
Copy link
Contributor Author

:( On it

@coveralls
Copy link

coveralls commented Apr 4, 2019

Coverage Status

Coverage increased (+0.1%) to 53.199% when pulling 8747a4f on corinagum:1827 into c7a39e6 on Microsoft:master.

@corinagum corinagum merged commit f68cf3c into microsoft:master Apr 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove "No renderer for this activity"
4 participants