Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Srravich/bugfix/1929 attachment #2068

Merged
merged 4 commits into from
Jan 30, 2020
Merged

Srravich/bugfix/1929 attachment #2068

merged 4 commits into from
Jan 30, 2020

Conversation

srinaath
Copy link
Contributor

@srinaath srinaath commented Jan 29, 2020 •
edited
Loading

Attachment bubble colors set

Before
before-filename-hidden

After

High Contrast Theme
Screen Shot 2020-01-29 at 12 50 09 PM

Dark Theme
Screen Shot 2020-01-29 at 12 50 18 PM

Light Theme
Screen Shot 2020-01-29 at 12 50 25 PM

Srinaath Ravichandran added 2 commits January 29, 2020 11:51
Added size and text color for attachments
9b4cfe4 
Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
Comment update
3c8710f 
Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
@coveralls
Copy link

coveralls commented Jan 29, 2020 •
edited
Loading

Coverage Status

Coverage increased (+0.01%) to 69.589% when pulling e9626ce on srravich/bugfix/1929-attachment into b024544 on master.

Test fixes
822ffe3 
Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
corinagum
corinagum previously approved these changes Jan 30, 2020
View reviewed changes
Copy link
Contributor

@corinagum corinagum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Updated download attachment style updated
e9626ce 
Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
@tdurnford
Copy link

It looks like microsoft/BotFramework-WebChat#2868 is removing the UploadAttachment component, so you may want to wait to make these changes until the Emulator bumps the Web Chat dependency to 4.8.0

@srinaath srinaath mentioned this pull request Jan 30, 2020
Closed
@srinaath
Copy link
Contributor Author

@tdurnford
Tracking this change in this ticket #2071. But, I think we still need to get this PR in until we bump Webchat dependency for Emulator. Currently the labels on Upload and Download Attachment are completely hidden. Once William's PR is merged I can change to target the FileAttachment class instead of DownloadAttachment. What do you think?

@tonyanziano tonyanziano merged commit 272b3c2 into master Jan 30, 2020
@tonyanziano tonyanziano deleted the srravich/bugfix/1929-attachment branch January 30, 2020 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonyanziano tonyanziano tonyanziano approved these changes

@corinagum corinagum corinagum left review comments

@cwhitten cwhitten Awaiting requested review from cwhitten

@compulim compulim Awaiting requested review from compulim

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n

@tdurnford tdurnford Awaiting requested review from tdurnford

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@srinaath @coveralls @tdurnford @tonyanziano @corinagum