Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove styling for download icon #2071

Closed
srinaath opened this issue Jan 30, 2020 · 0 comments · Fixed by #2088
Closed

Remove styling for download icon #2071

srinaath opened this issue Jan 30, 2020 · 0 comments · Fixed by #2088
Assignees
@srinaath
Labels
Bug Your classic code defect R8 Release 8 - March 16th, 2020

Comments

@srinaath
Copy link
Contributor

srinaath commented Jan 30, 2020 •
edited
Loading

Version

Stable master

Describe the bug

Currently, we add styling specific to download icon inside the parent DownloadAttachment. microsoft/BotFramework-WebChat#2868, this PR will be consolidating Upload and Download attachment as a single FileAttachment at which point when Emulator upgrades to WebChat 4.8 the styling change made in #2068 for download icon would have no effect.

Expected behavior

When Emulator bumps Webchat dependency to 4.8 ensure that styling for download icon under download attachment is replaced with FileAttachment.
@srinaath srinaath added Bug Your classic code defect R8 Release 8 - March 16th, 2020 labels Jan 30, 2020
@srinaath srinaath self-assigned this Jan 30, 2020
@srinaath srinaath mentioned this issue Jan 30, 2020
Merged
@srinaath srinaath added R8 Release 8 - March 16th, 2020 and removed R8 Release 8 - March 16th, 2020 labels Feb 24, 2020
@srinaath srinaath mentioned this issue Feb 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@srinaath srinaath

Labels
Bug Your classic code defect R8 Release 8 - March 16th, 2020
Projects
None yet
Milestone
No milestone
1 participant
@srinaath