Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: LG template go to definition in language server #6110

Merged
merged 34 commits into from
Mar 29, 2021
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
34 commits
Select commit Hold shift + click to select a range
4a51662
init
cosmicshuai Feb 25, 2021
ba685b4
Merge branch 'main' into shuwan/gotoDefinition
cosmicshuai Mar 3, 2021
98b99bc
add local file go to definition
cosmicshuai Mar 3, 2021
9141766
remove a console log
cosmicshuai Mar 3, 2021
01a0bd3
Merge branch 'main' into shuwan/gotoDefinition
cosmicshuai Mar 3, 2021
64e93de
fix a test
cosmicshuai Mar 3, 2021
d266ceb
Merge branch 'shuwan/gotoDefinition' of github.com:microsoft/BotFrame…
cosmicshuai Mar 3, 2021
753e512
Merge branch 'main' into shuwan/gotoDefinition
cosmicshuai Mar 16, 2021
5a50c17
Merge branch 'main' into shuwan/gotoDefinition
cosmicshuai Mar 16, 2021
36aab7c
add jump file notification
cosmicshuai Mar 16, 2021
1c48e62
Merge branch 'shuwan/gotoDefinition' of https://github.com/microsoft/…
cosmicshuai Mar 16, 2021
f7c1704
add templateId
cosmicshuai Mar 16, 2021
233224f
Merge branch 'main' into shuwan/gotoDefinition
cosmicshuai Mar 16, 2021
83ede8b
navigate to lg template defination
liweitian Mar 16, 2021
d3af153
Merge branch 'main' into shuwan/gotoDefinition
cosmicshuai Mar 17, 2021
88aadee
Merge branch 'main' into shuwan/gotoDefinition
cosmicshuai Mar 17, 2021
6dc31d8
change the place of a function call
cosmicshuai Mar 17, 2021
63d2a4c
Merge branch 'main' into shuwan/gotoDefinition
cosmicshuai Mar 18, 2021
0aceb77
Merge branch 'main' into shuwan/gotoDefinition
cosmicshuai Mar 18, 2021
0e5134f
Merge branch 'main' into shuwan/gotoDefinition
cosmicshuai Mar 22, 2021
0297d00
Merge branch 'main' into shuwan/gotoDefinition
cosmicshuai Mar 22, 2021
9ea673d
navigate to lg page on client
zhixzhan Mar 22, 2021
5dfd525
Merge branch 'main' into shuwan/gotoDefinition
cosmicshuai Mar 23, 2021
1fc177a
change to onNavigateLGPage
cosmicshuai Mar 23, 2021
4bc5587
Merge branch 'main' into shuwan/gotoDefinition
cosmicshuai Mar 24, 2021
86d30b4
fix multilanguage go to incorrect behaviors
cosmicshuai Mar 24, 2021
71eb4d7
Merge branch 'main' into shuwan/gotoDefinition
cosmicshuai Mar 24, 2021
3e3154c
remove a log statement
cosmicshuai Mar 25, 2021
9d76e40
Merge branch 'main' into shuwan/gotoDefinition
cosmicshuai Mar 25, 2021
a7961aa
Merge branch 'main' into shuwan/gotoDefinition
cosmicshuai Mar 26, 2021
c7ac9ef
fix signatures
cosmicshuai Mar 26, 2021
fa4835f
Merge branch 'main' of https://github.com/microsoft/BotFramework-Comp…
sorgh Mar 27, 2021
3cec9cf
removed logs and resovled conflicts
sorgh Mar 27, 2021
a035ca6
fix types
sorgh Mar 27, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,7 @@ const CodeEditor: React.FC<CodeEditorProps> = (props) => {
};

const navigateToLgPage = useCallback(
(lgFileId: string, options?: { templateId: string; line: number }) => {
(lgFileId: string, options?: { templateId: string | undefined; line: number | undefined }) => {
hatpick marked this conversation as resolved.
Show resolved Hide resolved
// eslint-disable-next-line security/detect-non-literal-regexp
const pattern = new RegExp(`.${locale}`, 'g');
const fileId = currentDialog.isFormDialog ? lgFileId : lgFileId.replace(pattern, '');
Expand All @@ -186,8 +186,9 @@ const CodeEditor: React.FC<CodeEditorProps> = (props) => {
: `/bot/${actualProjectId}/language-generation/${fileId}`;
if (options?.line) {
url = url + `/edit#L=${options.line}`;
} else if (options?.templateId) {
url = url + `/edit?t=${options.templateId}`;
}

navigateTo(url);
},
[actualProjectId, locale]
Expand Down
10 changes: 4 additions & 6 deletions Composer/packages/lib/code-editor/src/lg/LgCodeEditor.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,7 @@ export const LgCodeEditor = (props: LgCodeEditorProps) => {
languageClient.onReady().then(() =>
languageClient.onNotification('GotoDefinition', (result) => {
if (lgOption?.projectId) {
console.log('Navi', onNavigateToLgPage);
hatpick marked this conversation as resolved.
Show resolved Hide resolved
onNavigateToLgPage?.(result.fileId, { templateId: result.templateId, line: result.line });
}
})
Expand All @@ -160,6 +161,7 @@ export const LgCodeEditor = (props: LgCodeEditorProps) => {
window.monacoLGEditorInstance.onReady().then(() =>
window.monacoLGEditorInstance.onNotification('GotoDefinition', (result) => {
if (lgOption?.projectId) {
console.log('Navi', onNavigateToLgPage);
onNavigateToLgPage?.(result.fileId, { templateId: result.templateId, line: result.line });
}
})
Expand Down Expand Up @@ -200,7 +202,7 @@ export const LgCodeEditor = (props: LgCodeEditorProps) => {
);

const navigateToLgPage = React.useCallback(() => {
onNavigateToLgPage?.(lgOption?.fileId ?? 'common', lgOption?.templateId);
onNavigateToLgPage?.(lgOption?.fileId ?? 'common', { templateId: lgOption?.templateId, line: undefined });
}, [onNavigateToLgPage, lgOption]);

const onExpandedEditorChange = React.useCallback(
Expand Down Expand Up @@ -273,11 +275,7 @@ export const LgCodeEditor = (props: LgCodeEditorProps) => {
popExpandOptions?.onEditorPopToggle?.(false);
}}
>
<LgCodeEditor
{...omit(props, ['onNavigateToLgPage', 'popExpandOptions'])}
height={400}
onChange={onExpandedEditorChange}
/>
<LgCodeEditor {...omit(props, ['popExpandOptions'])} height={400} onChange={onExpandedEditorChange} />
hatpick marked this conversation as resolved.
Show resolved Hide resolved
</Dialog>
)}
</>
Expand Down