Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: LG template go to definition in language server #6110

Merged
merged 34 commits into from
Mar 29, 2021

Conversation

cosmicshuai
Copy link
Contributor

@cosmicshuai cosmicshuai commented Mar 3, 2021

closes #5522

Add go to definition for LG templates.
While editing LG files, once user hit crtl+right click on a template name call in expression. The editor will bring the cursor to the location where the template is defined.
Features:

  1. Goto Definition in LG all up view
    AllUpViewNavigate

  2. Goto Definition in LG imports
    ImportNavigate

  3. Goto definition in inline LG editor
    InLineNavigate

  4. Goto definition in form dialog
    FormNavigate

  5. Goto Definition in form dialog imports
    FormImportNavigate

@coveralls
Copy link

coveralls commented Mar 3, 2021

Coverage Status

Coverage decreased (-0.1%) to 51.865% when pulling a035ca6 on shuwan/gotoDefinition into 236ceac on main.

@cosmicshuai cosmicshuai requested a review from hatpick March 23, 2021 09:14
hatpick
hatpick previously approved these changes Mar 24, 2021
@cosmicshuai cosmicshuai merged commit 1bfe853 into main Mar 29, 2021
@cosmicshuai cosmicshuai deleted the shuwan/gotoDefinition branch March 29, 2021 01:42
@cwhitten cwhitten mentioned this pull request May 20, 2021
lei9444 pushed a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
* init

* add local file go to definition

* remove a console log

* fix a test

* add jump file notification

* add templateId

* navigate to lg template defination

* change the place of a function call

* navigate to lg page on client

* change to onNavigateLGPage

* fix multilanguage go to incorrect behaviors

* remove a log statement

* fix signatures

* removed logs and resovled conflicts

* fix types

Co-authored-by: liweitian <liweitian93@outlook.com>
Co-authored-by: Zhixiang Zhan <zhixzhan@microsoft.com>
Co-authored-by: Soroush <sorgh@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support LG template navigation
6 participants